Skip to content

fix: filters affected by mapping inheritance issue #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2023
Merged

fix: filters affected by mapping inheritance issue #2121

merged 2 commits into from
Mar 27, 2023

Conversation

allisonsuarez
Copy link
Contributor

Description

Motivation and Context

How Has This Been Tested?

Documentation

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@allisonsuarez
fix inheritance issue
9893b84 
Signed-off-by: Allison Suarez Miranda <[email protected]>
@boring-cyborg boring-cyborg bot added the area:search From the search folder label Mar 21, 2023
@allisonsuarez
Copy link
Contributor Author

Fixes issue #2120

@allisonsuarez allisonsuarez mentioned this pull request Mar 21, 2023
Closed
@allisonsuarez allisonsuarez marked this pull request as ready for review March 21, 2023 17:51
@allisonsuarez allisonsuarez requested a review from a team as a code owner March 21, 2023 17:51
@allisonsuarez
Copy link
Contributor Author

Fix is in this line https://github.com/amundsen-io/amundsen/pull/2121/files#diff-623a25aadddbaf767e7af71707f012516a9913d0fcdbdd1eb5a95d04ec3c52feR199

@allisonsuarez
bump search package version
f3b45ce 
Signed-off-by: Allison Suarez Miranda <[email protected]>
@allisonsuarez allisonsuarez merged commit b6576d3 into main Mar 27, 2023
@allisonsuarez allisonsuarez deleted the asm-filter-fix branch March 27, 2023 22:31
@allisonsuarez allisonsuarez restored the asm-filter-fix branch March 27, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristenarmes kristenarmes kristenarmes approved these changes

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@jinhyukchang jinhyukchang Awaiting requested review from jinhyukchang jinhyukchang is a code owner

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin bolkedebruin is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@dkunitsk dkunitsk Awaiting requested review from dkunitsk dkunitsk is a code owner

Assignees
No one assigned
Labels
area:search From the search folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonsuarez @kristenarmes