fix: Use managed read transactions for queries in metadata service #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristen Armes <[email protected]>
kristenarmes
requested review from
feng-tao,
jinhyukchang,
allisonsuarez,
verdan,
bolkedebruin,
mgorsk1,
dorianj,
youngyjd,
dechoma,
sewardgw,
dkunitsk and
a team
as code owners
| if LOGGER.isEnabledFor(logging.DEBUG): | ||
| LOGGER.debug('Executing Cypher query: {statement} with params {params}: '.format(statement=statement, | ||
| params=param_dict)) | ||
| start = time.time() | ||
| try: | ||
| with self._driver.session(database=self._database_name) as session: | ||
| result = session.run(query=statement, **param_dict) | ||
| return [record for record in result] | ||
| return session.read_transaction(execute_statement, statement, param_dict) |
There was a problem hiding this comment.
can we make the return the same on the execute_statement function. So rather than doing .data() doing [record for record in result]. I am not sure if using .data() could cause a mismatch in the expected returned data type.
There was a problem hiding this comment.
yes this is a good point, I was having trouble getting the results originally so I thought it needed to be done a different way, but turns out I was just doing it in the wrong spot. just updated this so the original return way is used, but just in the transaction function instead of here
Signed-off-by: Kristen Armes <[email protected]>
allisonsuarez
approved these changes
Mar 22, 2023
B-T-D
pushed a commit
to B-T-D/amundsen
that referenced
this pull request
Mar 29, 2023
…mundsen-io#2119) * Use managed read transactions for queries in metadata service Signed-off-by: Kristen Armes <[email protected]> * Return same type as before Signed-off-by: Kristen Armes <[email protected]> --------- Signed-off-by: Kristen Armes <[email protected]> Signed-off-by: Ben Dye <[email protected]>
B-T-D
pushed a commit
to B-T-D/amundsen
that referenced
this pull request
Mar 29, 2023
…mundsen-io#2119) * Use managed read transactions for queries in metadata service Signed-off-by: Kristen Armes <[email protected]> * Return same type as before Signed-off-by: Kristen Armes <[email protected]> --------- Signed-off-by: Kristen Armes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating metadata GET APIs to use managed read transactions in the Neo4j proxy to provide retry capabilities.
Motivation and Context
We were having an issue with errors with our health check where our Neo4j instance was showing that our client connection was closing, so trying this out to see if it fixes the issue. In any case, it is the Neo4j recommended way of executing transactions.
How Has This Been Tested?
Documentation
N/A
CheckList