Skip to content

feat: add programmatic descriptions to feature details page #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

allisonsuarez
Copy link
Contributor

@allisonsuarez allisonsuarez commented Mar 14, 2023

Description

  • Added left, right, other, programmatic descriptions sections to the feature details page

Motivation and Context

  • achieve parity with other resources

How Has This Been Tested?

  • ran locally

Documentation

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
@allisonsuarez allisonsuarez merged commit 99faa2a into main Mar 14, 2023
@allisonsuarez allisonsuarez deleted the asm-prog-des-features branch March 14, 2023 22:26
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
…-io#2115)

* feat: add programmatic descriptions to feature details page

Signed-off-by: Allison Suarez Miranda <[email protected]>

* feedback and lint

Signed-off-by: Allison Suarez Miranda <[email protected]>

* fix lint

Signed-off-by: Allison Suarez Miranda <[email protected]>

---------

Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
…-io#2115)

* feat: add programmatic descriptions to feature details page

Signed-off-by: Allison Suarez Miranda <[email protected]>

* feedback and lint

Signed-off-by: Allison Suarez Miranda <[email protected]>

* fix lint

Signed-off-by: Allison Suarez Miranda <[email protected]>

---------

Signed-off-by: Allison Suarez Miranda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants