Skip to content

chore: adds page view tracking via logAction #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2023
Merged

chore: adds page view tracking via logAction #2114

merged 2 commits into from
Mar 14, 2023

Conversation

Golodhros
Copy link
Member

Summary of Changes

Adds page view tracking via our log tracker method

Tests

Tested manually

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@boring-cyborg boring-cyborg bot added the area:frontend From the Frontend folder label Mar 13, 2023
@Golodhros Golodhros force-pushed the mi-page-view-logging branch from 5311132 to 49d3eee Compare March 13, 2023 23:50
@Golodhros Golodhros marked this pull request as ready for review March 13, 2023 23:50
@Golodhros Golodhros force-pushed the mi-page-view-logging branch from 9c800c1 to 9332f0e Compare March 14, 2023 03:55
@Golodhros Golodhros merged commit 3e329fc into main Mar 14, 2023
@Golodhros Golodhros deleted the mi-page-view-logging branch March 14, 2023 04:04
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
@Golodhros @B-T-D
chore: adds page view tracking via logAction (amundsen-io#2114)
04b2a18 
* chore: adds page view tracking via logAction

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: updates PR template and adds PRLint configuration

Signed-off-by: Marcos Iglesias <[email protected]>

---------

Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
@Golodhros @B-T-D
chore: adds page view tracking via logAction (amundsen-io#2114)
772b649 
* chore: adds page view tracking via logAction

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: updates PR template and adds PRLint configuration

Signed-off-by: Marcos Iglesias <[email protected]>

---------

Signed-off-by: Marcos Iglesias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristenarmes kristenarmes kristenarmes approved these changes

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

@allisonsuarez allisonsuarez Awaiting requested review from allisonsuarez allisonsuarez is a code owner

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

Assignees
No one assigned
Labels
area:dev-tools area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Golodhros @kristenarmes