feat: adds support for app suite links dropdown menu #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: adds Grid icon feat: adds app suite links configuration; tweaks popover radius chore: adds storybook and refactors styles docs: adds documentation for navLinks docs: updates application docs; reorganizes them and adds placeholders for missing ones Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Golodhros
commented
Mar 9, 2023
frontend/docs/application_config.md
Outdated
| @@ -245,6 +392,81 @@ navTheme: 'light', | |||
| Which would render like the following: | |||
| <img src='img/header-light-default-logo.png' width='50%' /> | |||
|
|
|||
| ## Nested Columns | |||
| *TODO | |||
There was a problem hiding this comment.
Would love your help @kristenarmes with this one
Golodhros
commented
Mar 9, 2023
|
|
||
| ## Table Lineage | ||
|
|
||
| _TODO: Please add doc_ | ||
| *TODO |
There was a problem hiding this comment.
Would love your help @allisonsuarez with this one
There was a problem hiding this comment.
does this include the Amundsen graph UI or just the up/downstream lineage tabs?
Signed-off-by: Marcos Iglesias <[email protected]>
Golodhros
requested review from
ttannis,
allisonsuarez,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd,
dechoma,
kristenarmes and
a team
as code owners
Signed-off-by: Marcos Iglesias <[email protected]>
| /* Tour step tooltip content container */ | ||
| .react-joyride__tooltip { | ||
| border-radius: $popover-border-radius !important; |
There was a problem hiding this comment.
is it necessary to use !important here?
There was a problem hiding this comment.
Yeah, not ideal but yes.
It is usually OK to do this when dealing with third party component customization though.
| @@ -211,6 +249,62 @@ Introducing dashboards into Amundsen allows users to discovery data analysis tha | |||
|
|
|||
| After ingesting dashboard metadata into the search and metadata services, set `IndexDashboardsConfig.enabled` to `true` on the application configuration to display the UI for the aforementioned features. | |||
|
|
|||
| ### Index Features | |||
| *TODO | |||
There was a problem hiding this comment.
is there something we need to add here?
There was a problem hiding this comment.
Yes, there is info for the other index options, but not for this one.
Ideally a short explanation and an example of how to set the flag (trivial, I know)
| target_id: '', | ||
| command: 'click', | ||
| target_type: 'button', | ||
| label: isOpen ? 'Open App Suite Menu' : 'Close App Suite Menu', |
There was a problem hiding this comment.
can we make these strings into constants?
There was a problem hiding this comment.
I usually don't do it for tracking messages, but yes, I can do that.
Co-authored-by: Kristen Armes <[email protected]> Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
kristenarmes
approved these changes
Mar 10, 2023
B-T-D
pushed a commit
to B-T-D/amundsen
that referenced
this pull request
Mar 29, 2023
* feat: adds navAppSuite configuration option and docs feat: adds Grid icon feat: adds app suite links configuration; tweaks popover radius chore: adds storybook and refactors styles docs: adds documentation for navLinks docs: updates application docs; reorganizes them and adds placeholders for missing ones Signed-off-by: Marcos Iglesias <[email protected]> * chore: updates tour radius styles Signed-off-by: Marcos Iglesias <[email protected]> * chore: tweaks Signed-off-by: Marcos Iglesias <[email protected]> * chore: removes 15 ESLint warnings Signed-off-by: Marcos Iglesias <[email protected]> * Update frontend/docs/application_config.md Co-authored-by: Kristen Armes <[email protected]> Signed-off-by: Marcos Iglesias <[email protected]> * chore: moves tracking messages to constants Signed-off-by: Marcos Iglesias <[email protected]> --------- Signed-off-by: Marcos Iglesias <[email protected]> Co-authored-by: Kristen Armes <[email protected]> Signed-off-by: Ben Dye <[email protected]>
B-T-D
pushed a commit
to B-T-D/amundsen
that referenced
this pull request
Mar 29, 2023
* feat: adds navAppSuite configuration option and docs feat: adds Grid icon feat: adds app suite links configuration; tweaks popover radius chore: adds storybook and refactors styles docs: adds documentation for navLinks docs: updates application docs; reorganizes them and adds placeholders for missing ones Signed-off-by: Marcos Iglesias <[email protected]> * chore: updates tour radius styles Signed-off-by: Marcos Iglesias <[email protected]> * chore: tweaks Signed-off-by: Marcos Iglesias <[email protected]> * chore: removes 15 ESLint warnings Signed-off-by: Marcos Iglesias <[email protected]> * Update frontend/docs/application_config.md Co-authored-by: Kristen Armes <[email protected]> Signed-off-by: Marcos Iglesias <[email protected]> * chore: moves tracking messages to constants Signed-off-by: Marcos Iglesias <[email protected]> --------- Signed-off-by: Marcos Iglesias <[email protected]> Co-authored-by: Kristen Armes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds support for a configurable app suite links dropdown
Adds docs and tests
Reorganizes application docs, adds placeholders to missing items
Reworks styling and border radius of all popovers and modals
Screenshots
Tests
Updated tests
Documentation
Added docs
Added story
CheckList
Make sure you have checked all steps below to ensure a timely review.