feat: adds light themed header option #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Golodhros
force-pushed
the
mi-light-header
branch
from
ecc1c8b to
d0c556d
Compare
Golodhros
requested review from
ttannis,
allisonsuarez,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd,
dechoma,
kristenarmes and
a team
as code owners
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
kristenarmes
approved these changes
Mar 9, 2023
| { | ||
| target: '.nav-bar-left a', | ||
| title: 'Title about the logo', | ||
| content: 'Content about the step pointing to the log', |
| { | ||
| target: '#search-input', | ||
| title: 'Search ranking', | ||
| content: 'Search raking information', |
There was a problem hiding this comment.
Suggested change
| content: 'Search raking information', | |
| content: 'Search ranking information', |
Signed-off-by: Marcos Iglesias <[email protected]>
B-T-D
pushed a commit
to B-T-D/amundsen
that referenced
this pull request
Mar 29, 2023
* feat: adds navTheme option for dark/light navigation; includes docs Signed-off-by: Marcos Iglesias <[email protected]> * feat: transforms theme configuration into a class Signed-off-by: Marcos Iglesias <[email protected]> * feat: updates styles, elevation and spacing for light themed navigation Signed-off-by: Marcos Iglesias <[email protected]> * feat: polishes logo placement Signed-off-by: Marcos Iglesias <[email protected]> * docs: updates application configuration Signed-off-by: Marcos Iglesias <[email protected]> * docs: added images Signed-off-by: Marcos Iglesias <[email protected]> * chore: adds story for NavBar Signed-off-by: Marcos Iglesias <[email protected]> * chore: fixes story Signed-off-by: Marcos Iglesias <[email protected]> * docs: typos fixing Signed-off-by: Marcos Iglesias <[email protected]> --------- Signed-off-by: Marcos Iglesias <[email protected]> Signed-off-by: Ben Dye <[email protected]>
B-T-D
pushed a commit
to B-T-D/amundsen
that referenced
this pull request
Mar 29, 2023
* feat: adds navTheme option for dark/light navigation; includes docs Signed-off-by: Marcos Iglesias <[email protected]> * feat: transforms theme configuration into a class Signed-off-by: Marcos Iglesias <[email protected]> * feat: updates styles, elevation and spacing for light themed navigation Signed-off-by: Marcos Iglesias <[email protected]> * feat: polishes logo placement Signed-off-by: Marcos Iglesias <[email protected]> * docs: updates application configuration Signed-off-by: Marcos Iglesias <[email protected]> * docs: added images Signed-off-by: Marcos Iglesias <[email protected]> * chore: adds story for NavBar Signed-off-by: Marcos Iglesias <[email protected]> * chore: fixes story Signed-off-by: Marcos Iglesias <[email protected]> * docs: typos fixing Signed-off-by: Marcos Iglesias <[email protected]> --------- Signed-off-by: Marcos Iglesias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds an option to make the navigation into a light theme
Tweaks styles, spacing and header elevation
Screenshots
Dark header with no logo
Light header with no logo
Dark header with logo
Documentation
Updated config docs
Added Storybook story:
CheckList
Make sure you have checked all steps below to ensure a timely review.