Skip to content

doc: update readme #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2023
Merged

doc: update readme #2110

merged 1 commit into from
Mar 6, 2023

Conversation

feng-tao
Copy link
Member

@feng-tao feng-tao commented Mar 4, 2023

Summary of Changes

update readme given we stop using amundsen internally at dbx.

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@feng-tao
doc: update readme
1ffda06 
Signed-off-by: feng-tao <[email protected]>
@feng-tao feng-tao requested review from Golodhros and youngyjd March 4, 2023 02:21
@feng-tao feng-tao requested a review from a team as a code owner March 4, 2023 02:21
Golodhros
Golodhros approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

😿

Don't tell me you use DataHub now!

@feng-tao
Copy link
Member Author

feng-tao commented Mar 6, 2023

LGTM

😿

Don't tell me you use DataHub now!

nah, we are building something similar into databricks saas product

@feng-tao feng-tao merged commit ccc1f19 into main Mar 6, 2023
@feng-tao feng-tao deleted the tfeng_remove_readme_1 branch March 6, 2023 16:17
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
@feng-tao @B-T-D
doc: update readme (amundsen-io#2110)
0e6eef9 
Signed-off-by: feng-tao <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
@feng-tao @B-T-D
doc: update readme (amundsen-io#2110)
120e79c 
Signed-off-by: feng-tao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Golodhros Golodhros Golodhros approved these changes

@youngyjd youngyjd Awaiting requested review from youngyjd

Assignees
No one assigned
Labels
area:dev-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feng-tao @Golodhros