Skip to content

docs: updates application configuration docs #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 28, 2023
Merged

docs: updates application configuration docs #2107

merged 4 commits into from
Feb 28, 2023

Conversation

Golodhros
Copy link
Member

Summary of Changes

Adds and updates some Frontend app configuration documents
Organizes configuration object alphabetically

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@boring-cyborg boring-cyborg bot added area:docs area:frontend From the Frontend folder labels Feb 28, 2023
Golodhros
Golodhros commented Feb 28, 2023
View reviewed changes
frontend/docs/application_config.md
```

## Column Lineage
*TODO
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allisonsuarez would love your help for this one, I guess you have it fresh.

@Golodhros
Copy link
Member Author

/ptal @kristenarmes

kristenarmes
kristenarmes approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@kristenarmes kristenarmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just commented on a few small spelling/wordings

Golodhros and others added 4 commits February 28, 2023 11:45
@Golodhros
docs: updates application configuration docs
96ea10b 
Signed-off-by: Marcos Iglesias <[email protected]>
@Golodhros @kristenarmes
Update frontend/docs/application_config.md
8faf195 
Co-authored-by: Kristen Armes <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
@Golodhros @kristenarmes
Update frontend/docs/application_config.md
1d41884 
Co-authored-by: Kristen Armes <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
@Golodhros @kristenarmes
Update frontend/docs/application_config.md
005035a 
Co-authored-by: Kristen Armes <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
@Golodhros Golodhros merged commit 0bf4ddb into main Feb 28, 2023
@Golodhros Golodhros deleted the mi-app-config branch February 28, 2023 21:28
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
@Golodhros @kristenarmes @B-T-D
docs: updates application configuration docs (amundsen-io#2107)
97ab42b 
* docs: updates application configuration docs

Signed-off-by: Marcos Iglesias <[email protected]>

* Update frontend/docs/application_config.md

Co-authored-by: Kristen Armes <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>

* Update frontend/docs/application_config.md

Co-authored-by: Kristen Armes <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>

* Update frontend/docs/application_config.md

Co-authored-by: Kristen Armes <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>

---------

Signed-off-by: Marcos Iglesias <[email protected]>
Co-authored-by: Kristen Armes <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
@Golodhros @kristenarmes @B-T-D
docs: updates application configuration docs (amundsen-io#2107)
ba3c8b3 
* docs: updates application configuration docs

Signed-off-by: Marcos Iglesias <[email protected]>

* Update frontend/docs/application_config.md

Co-authored-by: Kristen Armes <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>

* Update frontend/docs/application_config.md

Co-authored-by: Kristen Armes <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>

* Update frontend/docs/application_config.md

Co-authored-by: Kristen Armes <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>

---------

Signed-off-by: Marcos Iglesias <[email protected]>
Co-authored-by: Kristen Armes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristenarmes kristenarmes kristenarmes approved these changes

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

@allisonsuarez allisonsuarez Awaiting requested review from allisonsuarez allisonsuarez is a code owner

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

Assignees
No one assigned
Labels
area:docs area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Golodhros @kristenarmes