Skip to content

chore: cleans and refactors global navbar code #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2023
Merged

chore: cleans and refactors global navbar code #2098

merged 3 commits into from
Feb 7, 2023

Conversation

Golodhros
Copy link
Member

Summary of Changes

Cleans up code and extract components on the global navigation of Amundsen
Updates text styles
Cleans ESLint issues and Type warnings

Tests

Updated tests

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@boring-cyborg boring-cyborg bot added the area:frontend From the Frontend folder label Feb 7, 2023
@Golodhros Golodhros merged commit 169e269 into main Feb 7, 2023
@Golodhros Golodhros deleted the mi-navbar branch February 7, 2023 04:43
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
@Golodhros @B-T-D
chore: cleans and refactors global navbar code (amundsen-io#2098)
361b7f5 
* chore: navbar cleanup and tweaks

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: extracts logo component on navbar

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: fixes ESLint and type warnings

Signed-off-by: Marcos Iglesias <[email protected]>

---------

Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
@Golodhros @B-T-D
chore: cleans and refactors global navbar code (amundsen-io#2098)
0a99c0d 
* chore: navbar cleanup and tweaks

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: extracts logo component on navbar

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: fixes ESLint and type warnings

Signed-off-by: Marcos Iglesias <[email protected]>

---------

Signed-off-by: Marcos Iglesias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristenarmes kristenarmes kristenarmes approved these changes

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

@allisonsuarez allisonsuarez Awaiting requested review from allisonsuarez allisonsuarez is a code owner

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

Assignees
No one assigned
Labels
area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Golodhros @kristenarmes