feat: adds initial API files for notices endpoint #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: adds basic api file and test Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Golodhros
requested review from
ttannis,
allisonsuarez,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd,
dechoma and
kristenarmes
as code owners
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
kristenarmes
approved these changes
Feb 1, 2023
| @@ -207,10 +207,19 @@ export enum NoticeSeverity { | |||
| WARNING = 'warning', | |||
| ALERT = 'alert', | |||
There was a problem hiding this comment.
Does it make sense for the highest level to be called 'error' instead of 'alert'? not sure if 'alert' conveys to me that it would be a higher severity over a warning
There was a problem hiding this comment.
That's a good point. However, that would be a breaking change at this moment (this is from the currently working notices feature)
B-T-D
pushed a commit
to B-T-D/amundsen
that referenced
this pull request
Mar 29, 2023
* chore: adds fixture data for notices API chore: adds basic api file and test Signed-off-by: Marcos Iglesias <[email protected]> * chore: normalizes initialState for tags and badges Signed-off-by: Marcos Iglesias <[email protected]> * feat: adds notices sagas and related tests Signed-off-by: Marcos Iglesias <[email protected]> * chore: adds action tests Signed-off-by: Marcos Iglesias <[email protected]> * chore: adds reducer and tests Signed-off-by: Marcos Iglesias <[email protected]> * chore: updated rootReducer and rootSaga Signed-off-by: Marcos Iglesias <[email protected]> * chore: adds STATUS_CODES constants Signed-off-by: Marcos Iglesias <[email protected]> * chore: rolls out STATUS_CODES constants Signed-off-by: Marcos Iglesias <[email protected]> * chore: adds copyright messages Signed-off-by: Marcos Iglesias <[email protected]> * fix: fixes type issues Signed-off-by: Marcos Iglesias <[email protected]> * chore: using other data builder options to increase coverage Signed-off-by: Marcos Iglesias <[email protected]> * chore: move into testDataBuilder file and exclude from test coverage Signed-off-by: Marcos Iglesias <[email protected]> --------- Signed-off-by: Marcos Iglesias <[email protected]> Signed-off-by: Ben Dye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds reducer, actions, sagas and endpoints for the WIP notices endpoint
Creates STATUS_CODES constants for all status codes
Updated jest.config to not use testDataBuilder.ts files on test coverage report
Tests
Added tests
Related to the stretch goals on https://github.com/amundsen-io/rfcs/blob/master/rfcs/029-resource-notices.md