feat: adds dynamic notices flag on config #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golodhros
requested review from
ttannis,
allisonsuarez,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd,
dechoma and
kristenarmes
as code owners
kristenarmes
approved these changes
Jan 30, 2023
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Golodhros
force-pushed
the
mi-dynamic-notices-config
branch
from
0bc223d to
d776cc0
Compare
allisonsuarez
approved these changes
Jan 30, 2023
B-T-D
pushed a commit
to B-T-D/amundsen
that referenced
this pull request
Mar 29, 2023
* feat: adds dynamic notices flag on config Signed-off-by: Marcos Iglesias <[email protected]> * docs: updated docs Signed-off-by: Marcos Iglesias <[email protected]> --------- Signed-off-by: Marcos Iglesias <[email protected]> Signed-off-by: Ben Dye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds a configuration option to allow for dynamic fetching of notices for different resources
Tests
Added configuration util tests
Documentation
Updated docs
Related to the stretch goals on https://github.com/amundsen-io/rfcs/blob/master/rfcs/029-resource-notices.md