Fix: Enable neptune proxy custom sts endpoint #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 27, 2023 08:38
Signed-off-by: Jovi Loo <[email protected]>
Signed-off-by: Jovi Loo <[email protected]>
feng-tao
approved these changes
Jan 27, 2023
B-T-D
pushed a commit
to B-T-D/amundsen
that referenced
this pull request
Mar 29, 2023
* added option to specify sts endpoint in metadata service neptune proxy Signed-off-by: Jovi Loo <[email protected]> * added relevant documentation for neptune proxy sts endpoint Signed-off-by: Jovi Loo <[email protected]> --------- Signed-off-by: Jovi Loo <[email protected]> Signed-off-by: Ben Dye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Currently, when users deploy Amundsen with Neptune backend DB,
NeptuneBulkLoaderApiis instantiated with the default STS endpoint.However, this might not work when users deploy the service in government cloud / regional cloud, and the default endpoint is disabled. This PR allows user to specify the STS endpoint in the metadata config file, if they wish to.
Tests
No tests added because it does not change any application behavior. It only creates an option for user to specify their STS endpoint upfront in the config file.
Documentation
Added a line in
docs/tutorials/how-to-use-amundsen-with-aws-neptune.mdto explain that users can now specify STS endpoint.CheckList
Make sure you have checked all steps below to ensure a timely review.