Skip to content

fix: cleans ESLint issues with unused variables #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 12, 2023
Merged

Conversation

Golodhros
Copy link
Member

Summary of Changes

Removes instances where we weren't using variables
Updates ESLint rules to fail from now on

Tests

Manually tested
Ran tests

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@Golodhros Golodhros force-pushed the mi-clean-no-used-vars branch from 6641267 to 5ca0ce7 Compare January 11, 2023 23:42
Signed-off-by: Marcos Iglesias <[email protected]>
@Golodhros
Copy link
Member Author

/retest

Signed-off-by: Marcos Iglesias <[email protected]>
@Golodhros Golodhros merged commit 13166c6 into main Jan 12, 2023
@Golodhros Golodhros deleted the mi-clean-no-used-vars branch January 12, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants