Skip to content

fix: int is too small for a unix timestamp #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2023
Merged

fix: int is too small for a unix timestamp #2079

merged 2 commits into from
Jan 9, 2023

Conversation

allisonsuarez
Copy link
Contributor

@allisonsuarez allisonsuarez commented Jan 9, 2023 •
edited
Loading

Changed dashboard summary model in comment to use last_successful_run_timestamp: Optional[float] = None since a value like 1668725028.424 is too large to be casted to an int

@allisonsuarez
fox: int is too small for a unix timestamp
559d24c 
Signed-off-by: Allison Suarez Miranda <[email protected]>
@boring-cyborg boring-cyborg bot added area:common From common folder category:models labels Jan 9, 2023
@Golodhros Golodhros added type:bug An unexpected problem or unintended behavior status:completed Issue is completed and on master labels Jan 9, 2023
Golodhros
Golodhros approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allisonsuarez
removed upper bound for amundsen-common req
456239b 
Signed-off-by: Allison Suarez Miranda <[email protected]>
@allisonsuarez allisonsuarez merged commit a2cb0b2 into main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Golodhros Golodhros Golodhros approved these changes

@kristenarmes kristenarmes kristenarmes approved these changes

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@jinhyukchang jinhyukchang Awaiting requested review from jinhyukchang jinhyukchang is a code owner

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin bolkedebruin is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@dkunitsk dkunitsk Awaiting requested review from dkunitsk dkunitsk is a code owner

Assignees
No one assigned
Labels
area:common From common folder status:completed Issue is completed and on master type:bug An unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allisonsuarez @Golodhros @kristenarmes