Skip to content

doc: add two new docs to readme #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2022
Merged

doc: add two new docs to readme #2060

merged 1 commit into from
Dec 14, 2022

Conversation

feng-tao
Copy link
Member

Summary of Changes

add https://medium.com/@owenleung_89035/amundsen-installing-in-an-istio-enabled-environment-d0b9bdaeac49 and https://medium.com/@owenleung_89035/amundsen-integrate-with-okta-singlesignon-20ad0a22d3d9 to the readme

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@feng-tao feng-tao requested a review from a team as a code owner December 13, 2022 05:48
@boring-cyborg boring-cyborg bot added the area:all Related to all the project label Dec 13, 2022
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@feng-tao feng-tao merged commit 027ae0b into main Dec 14, 2022
@feng-tao feng-tao deleted the tfeng_update_readme2 branch December 14, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:all Related to all the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants