-
Notifications
You must be signed in to change notification settings - Fork 970
feat: extends resource notices to support extra information #2045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
e8e3278
to
18b71b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
onAction?.(e); | ||
setShowPayloadModal(true); | ||
|
||
console.log('see details!'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OH, thanks!
a867fe2
to
4b812db
Compare
Signed-off-by: Marcos Iglesias <[email protected]>
4b812db
to
23ce401
Compare
Summary of Changes
Extends the notices feature to support showing extra information about the notices
Creates reusable DefinitionList component
Tweaks button styles
Normalizes Modal styles
Tests
Added tests
Screenshots
Documentation
Updated
CheckList
Make sure you have checked all steps below to ensure a timely review.