Skip to content

feat: tweaks styling of Alerts #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2022
Merged

feat: tweaks styling of Alerts #2043

merged 4 commits into from
Dec 5, 2022

Conversation

Golodhros
Copy link
Member

Summary of Changes

Tweaks the alerts styling to be more eye-catching
Updated storybook

Tests

Ran tests
Tested manually

Screenshots

AMS

AMS_and_DESIGN_SYSTEMS

Documentation

Upated screenshots

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Copy link
Contributor

@kristenarmes kristenarmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! one small thing is the img called notices-warning-dashboard.png is a table view (rather than dashboard) could maybe just rename it for accuracy

@Golodhros
Copy link
Member Author

LGTM! one small thing is the img called notices-warning-dashboard.png is a table view (rather than dashboard) could maybe just rename it for accuracy

Makes sense, done!

Signed-off-by: Marcos Iglesias <[email protected]>
@Golodhros Golodhros merged commit e7ad6f8 into main Dec 5, 2022
@Golodhros Golodhros deleted the mi-alerts-tweaks branch December 5, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants