Skip to content

refactor - move homepage components in preparation implementation of configurable widgets. #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 7, 2022
Merged

refactor - move homepage components in preparation implementation of configurable widgets. #2041

merged 11 commits into from
Dec 7, 2022

Conversation

B-T-D
Copy link
Contributor

@B-T-D B-T-D commented Dec 1, 2022 •
edited
Loading

Summary of Changes

Put SearchBar into same div as other home page components, and move all those components into a new features/Widgets folder.

Tests

Updated tests to reflect the refactoring, and to resolve linting errors that were flagged as a result of the refactoring.

Documentation

None

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder category:ui labels Dec 1, 2022
B-T-D added 5 commits December 1, 2022 15:28
@B-T-D
run lint:fix
23cea12 
Signed-off-by: Ben Dye <[email protected]>
@B-T-D
Updates required by eslint
cb0904f 
Signed-off-by: Ben Dye <[email protected]>

Updates for linter

Signed-off-by: Ben Dye <[email protected]>

Changes caused by linter issues. Didn't need the lifecycle methods because the component will re-render automatically when setState is called to update the searchTerm. Removed the corresponding test.

Signed-off-by: Ben Dye <[email protected]>

Linter fixes for eslint / betterer

Signed-off-by: Ben Dye <[email protected]>
@B-T-D
More linter fixes
c1e4358 
Signed-off-by: Ben Dye <[email protected]>
@B-T-D
tab index numbering and period char
4ad1ff0 
Signed-off-by: Ben Dye <[email protected]>
@B-T-D
typo
cabcac9 
Signed-off-by: Ben Dye <[email protected]>
Golodhros
Golodhros reviewed Dec 5, 2022
View reviewed changes
...static/js/features/Widgets/SearchBar/InlineSearchResults/SearchItemList/tests/index.spec.tsx Outdated
Comment on lines 16 to 17
// ignore eslint rule about unused imports
import SearchItem from '../SearchItem'; // eslint-disable-line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are actually not using this at all.
What you have in line 28 is called the same way, but it could be called in any other way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep you were right--I updated it.

frontend/amundsen_application/static/js/pages/HomePage/styles.scss Outdated
@@ -6,6 +6,10 @@
.home-page {
.home-element-container {
margin-top: $spacer-4 * 2;

&:first-child {
margin-top: 0px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
margin-top: 0px;
margin-top: 0;

B-T-D added 3 commits December 5, 2022 18:59
@B-T-D
nit in stylesheet; go back to previous syntax for retrieving callback…
d7a7bda 
… from props

Signed-off-by: Ben Dye <[email protected]>
@B-T-D
Use destructuring for callbacks in props
b649311 
Signed-off-by: Ben Dye <[email protected]>
@B-T-D
# This is a combination of 2 commits.
45d88d6 
# This is the 1st commit message:

Cleanups, eslint fixes, and update directory structure

Signed-off-by: Ben Dye <[email protected]>

# This is the commit message #2:

Update directory structure

Signed-off-by: Ben Dye <[email protected]>
@B-T-D B-T-D marked this pull request as ready for review December 7, 2022 00:29
Golodhros
Golodhros approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Golodhros Golodhros merged commit 00b39d6 into amundsen-io:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Golodhros Golodhros Golodhros approved these changes

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

@allisonsuarez allisonsuarez Awaiting requested review from allisonsuarez allisonsuarez is a code owner

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

@kristenarmes kristenarmes Awaiting requested review from kristenarmes kristenarmes is a code owner

Assignees
No one assigned
Labels
area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@B-T-D @Golodhros