Fix: Corrected position of arguments in _par #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md) |
…obustness Signed-off-by: Jovi Loo <[email protected]>
joyaung
force-pushed
the
fix/gremlin-proxy-lineage-args
branch
from
561e34c to
9adb61f
Compare
feng-tao
approved these changes
Dec 7, 2022
feng-tao
reviewed
Dec 7, 2022
| @@ -1958,8 +1958,8 @@ def _get_edge_type_from_user_resource_rel_type(self, relation: UserResourceRel) | |||
|
|
|||
| raise NotImplementedError(f"Don't know how to handle UserResourceRel={relation}") | |||
|
|
|||
| def _parse_lineage(self, resource_type: ResourceType, type_: str, upstream_tables: List[LineageItem], path: Path, | |||
| downstream_tables: List[LineageItem]) -> Tuple[List[LineageItem], List[LineageItem]]: | |||
| def _parse_lineage(self, resource_type: ResourceType, type_: str, upstream_tables: List[LineageItem], | |||
There was a problem hiding this comment.
what is the main reason of the argument swap?
There was a problem hiding this comment.
Previously, parse_lineage function accepted arguments in the wrong order as it was called on line 2038. There are two possible fixes for this:
- Align the order of the arguments in
parse_lineageand line 2038. - Add kwargs
Technically, either one of the above fixes would work but I have included both.
Signed-off-by: Jovi Loo <[email protected]>
feng-tao
approved these changes
Dec 8, 2022
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
pathanddownstream_tablesarguments in_parse_lineagefunction.Tests
Test suites not relevant for this bug fix, but changes have been tested internally with Neptune server.
Documentation
No documentation to add as there is no change in behavior.
CheckList
Make sure you have checked all steps below to ensure a timely review.