Fix: Change default value for 'description' in BigQuery_metadata_extractor results #2034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Changed the default type of table and column description in BigQuery_metadata_extractor to None.
This change was made so that the table and columns descriptions entered through the UI persist in the backend db (mysql in our case).
Currently because the default is an empty string every time metadata is extracted from BigQuery the descriptions entered through the UI are overwritten by the empty string.
This can be avoided by making sure description is set to None if it does not exist.
https://github.com/amundsen-io/amundsen/blob/main/databuilder/databuilder/models/description_metadata.py#L75
Tests
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.