Skip to content

Fix: Change default value for 'description' in BigQuery_metadata_extractor results #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

sahithi03
Copy link
Contributor

@sahithi03 sahithi03 commented Nov 17, 2022

Summary of Changes

Changed the default type of table and column description in BigQuery_metadata_extractor to None.
This change was made so that the table and columns descriptions entered through the UI persist in the backend db (mysql in our case).
Currently because the default is an empty string every time metadata is extracted from BigQuery the descriptions entered through the UI are overwritten by the empty string.
This can be avoided by making sure description is set to None if it does not exist.
https://github.com/amundsen-io/amundsen/blob/main/databuilder/databuilder/models/description_metadata.py#L75

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@sahithi03 sahithi03 requested a review from a team as a code owner November 17, 2022 01:41
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label Nov 17, 2022
@sahithi03 sahithi03 force-pushed the Fix-BQ-Metadata-Extractor branch from 9c1befd to f117d6d Compare November 17, 2022 01:45
Signed-off-by: Sahithi Velma <[email protected]>
@sahithi03 sahithi03 force-pushed the Fix-BQ-Metadata-Extractor branch from 59b1cbf to 60c42c0 Compare November 17, 2022 03:18
@feng-tao feng-tao merged commit ec7d737 into amundsen-io:main Nov 18, 2022
@sahithi03
Copy link
Contributor Author

Hi @feng-tao, thanks for reviewing! Can I send a PR updating the patch version to have a new release of databuilder?

@feng-tao
Copy link
Member

sure, I could help to trigger a release

@sahithi03
Copy link
Contributor Author

Hi @feng-tao, I've created a PR #2056 for updating the patch version, please help trigger a release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants