Skip to content

chore:feedback cleanup #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 11, 2022
Merged

chore:feedback cleanup #2027

merged 5 commits into from
Nov 11, 2022

Conversation

Golodhros
Copy link
Member

Summary of Changes

Cleanups and eslint rule tweaks

Tests

Ran tests

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder category:ui labels Nov 11, 2022
allisonsuarez
allisonsuarez approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@allisonsuarez allisonsuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Marcos!

@Golodhros Golodhros merged commit e0373e1 into main Nov 11, 2022
@Golodhros Golodhros deleted the mi-feedback-cleanup branch November 11, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonsuarez allisonsuarez allisonsuarez approved these changes

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

@kristenarmes kristenarmes Awaiting requested review from kristenarmes kristenarmes is a code owner

Assignees
No one assigned
Labels
area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Golodhros @allisonsuarez