Skip to content

chore: support amundsen-rds == 0.0.7 for mysql_proxy in metadata_service #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

xuan616
Copy link
Member

@xuan616 xuan616 commented Nov 6, 2022

Summary of Changes

  • supported amundsen-rds == 0.0.7 for mysql_proxy.py and support sqlalchemy >= 1.4, which is a change coming from amundsen-rds.
  • removed redundant package dependency for rds in setup.py

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@feng-tao feng-tao merged commit 8651318 into amundsen-io:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metadata From the metadata folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants