Skip to content

fix: fixes scrolling issue after tab changes #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2022
Merged

fix: fixes scrolling issue after tab changes #2021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b8995f
fix: fixes weird scrolling issue
Golodhros Nov 3, 2022
f558a9f
chore: betterer update
Golodhros Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions frontend/amundsen_application/static/.betterer.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,9 +597,6 @@ exports[`eslint`] = {
[13, 0, 454, "Component should be written as a pure function", "1437366564"],
[15, 35, 20, "Must use destructuring props assignment", "2510284131"]
],
"js/pages/TableDetailPage/FrequentUsers/index.tsx:14585253": [
[62, 11, 26, "A form label must be associated with a control.", "2816972347"]
],
"js/pages/TableDetailPage/ListSortingDropdown/index.tsx:286421664": [
[64, 25, 1, "\'_\' is defined but never used.", "177658"],
[67, 14, 204, "A control must be associated with a text label.", "3622841199"]
Expand Down Expand Up @@ -631,7 +628,7 @@ exports[`eslint`] = {
"js/pages/TableDetailPage/TableOwnerEditor/index.spec.tsx:3400494524": [
[3, 12, 5, "\'React\' is defined but never used.", "229961444"]
],
"js/pages/TableDetailPage/index.tsx:2409217356": [
"js/pages/TableDetailPage/index.tsx:857068198": [
[164, 2, 20, "key should be placed after componentWillUnmount", "3916788587"],
[217, 6, 13, "Do not use setState in componentDidUpdate", "57229240"]
],
Expand Down
1 change: 0 additions & 1 deletion frontend/amundsen_application/static/.betterer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ export default {
'react/prefer-stateless-function': 'error',
'react/sort-comp': 'error',
'react/static-property-placement': 'error',
'jsx-a11y/label-has-associated-control': 'error',
'jsx-a11y/control-has-associated-label': 'error',
'jsx-a11y/click-events-have-key-events': 'error',
'jsx-a11y/no-noninteractive-element-interactions': 'error',
Expand Down
1 change: 1 addition & 0 deletions frontend/amundsen_application/static/js/components/Tour/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const DEFAULT_CONFIGURATION = {
scrollToFirstStep: true,
showSkipButton: true,
disableScrolling: true,
disableScrollParentFix: true,
styles: {
options: {
textColor: GRAY_100,
Expand Down
1 change: 1 addition & 0 deletions frontend/amundsen_application/static/js/pages/TableDetailPage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,7 @@ export class TableDetail extends React.Component<
!newColumnDetails.isNestedColumn
) {
const { name, tableParams } = newColumnDetails;

getColumnLineageDispatch(buildTableKey(tableParams), name);
}

Expand Down
10 changes: 7 additions & 3 deletions frontend/amundsen_application/static/js/utils/navigationUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,22 +131,26 @@ export function getLoggingParams(search: string): {
}

export function getUrlParam(key: string): string {
const params = qs.parse(location.search);
const params = qs.parse(window.location.search);

return params[key];
}

export function setUrlParam(key: string, value: string) {
const params = qs.parse(location.search);
const params = qs.parse(window.location.search);

params[key] = value;
const queryString = qs.stringify(params);
BrowserHistory.replace(`${location.pathname}?${queryString}`);

BrowserHistory.replace(`${window.location.pathname}?${queryString}`);
}

export const getColumnLink = (
tableParams: TablePageParams,
columnName: string
) => {
const { cluster, database, schema, table } = tableParams;

return (
window.location.origin +
`/table_detail/${cluster}/${database}/${schema}/${table}` +
Expand Down