Skip to content

fix: adds loading spinners to table lineage tabs #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

Golodhros
Copy link
Member

@Golodhros Golodhros commented Oct 26, 2022

Summary of Changes

Adds loading spinners to the table lineage tabs
Makes it consistent with the dashboard tab loading state

Tests

Added tests

Screenshots

AMS

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Copy link
Contributor

@allisonsuarez allisonsuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a message for when the lineage is empty saying "no upstream/downstream lineage." within the tab itself?

Copy link
Contributor

@allisonsuarez allisonsuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tysm Marcos this is great!

@allisonsuarez allisonsuarez merged commit e1e8048 into main Oct 27, 2022
@allisonsuarez allisonsuarez deleted the mi-loading-lineage branch October 27, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants