fix: better styling for disabled items #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
allisonsuarez
commented
Oct 18, 2022
allisonsuarez
commented
- when a list item is disabled it should look different than the ones that are still enabled to avoid user confusion
Signed-off-by: Allison Suarez Miranda <[email protected]>
allisonsuarez
requested review from
Golodhros,
ttannis,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd and
dechoma
as code owners
Golodhros
reviewed
Oct 18, 2022
| pointer-events: none; | ||
| cursor: not-allowed; | ||
| .resource-icon { | ||
| filter: grayscale(80%); |
There was a problem hiding this comment.
Hmmm... Can you tell me more about why we use this? It is a non-conventional way.
There was a problem hiding this comment.
I needed to add some sort of visual indicator that the table item is not actionable (won't go to a table page), and it felt like just the table name being gray was not enough. There is a ss showing what it looks like. Is there a better way of doing this?
Golodhros
reviewed
Oct 18, 2022
frontend/amundsen_application/static/js/components/ResourceListItem/TableListItem/index.tsx
Outdated
Show resolved
Hide resolved
Golodhros
reviewed
Oct 18, 2022
| .resource-icon { | ||
| filter: grayscale(80%); | ||
| } | ||
| .resource-info .resource-info-text .resource-name { |
There was a problem hiding this comment.
Would this work with just '.resource-name'?
There was a problem hiding this comment.
it doesn't I tried to use a less specific one and the purple styling kept coming through
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.