Skip to content

feat: added optional in_amundsen bool to lineage items #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 18, 2022

Conversation

allisonsuarez
Copy link
Contributor

  • Allow metadata to return an in_amundsen field for each lineage item so that table links can be disabled if a table that showed up in lineage data doesn't currently exist in Amundsen (ex: temporary tables)

Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allisonsuarez allisonsuarez merged commit 73d7dc1 into main Oct 18, 2022
@allisonsuarez allisonsuarez deleted the asm-fix-lineage branch October 18, 2022 00:05
@MrwanBaghdad
Copy link
Contributor

How's the LineageItem meant to be used with TableLineage object in the data builder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:common From common folder area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants