feat: use different internal link than the table details page on lineage #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
allisonsuarez
commented
Oct 11, 2022
allisonsuarez
commented
- use a link received from metadata that is different than the one that directs you to a new table details page for the table items list
Signed-off-by: Allison Suarez Miranda <[email protected]>
allisonsuarez
requested review from
Golodhros,
ttannis,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd and
dechoma
as code owners
Signed-off-by: Allison Suarez Miranda <[email protected]>
allisonsuarez
requested review from
jinhyukchang,
bolkedebruin,
dkunitsk and
a team
as code owners
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
feng-tao
reviewed
Oct 12, 2022
| @@ -17,6 +17,7 @@ class LineageItem: | |||
| badges: Optional[List[Badge]] = None | |||
| usage: Optional[int] = None # statistic to sort lineage items by | |||
| parent: Optional[str] = None # key of the parent entity, used to create the relationships in graph | |||
| link: Optional[str] = None # internal link to redirect to different than the resource details page | |||
There was a problem hiding this comment.
@allisonsuarez do you compute lineage internally now at Lyft? or still rely on 3rd party tool like complierworks?
There was a problem hiding this comment.
We are doing it in house now
There was a problem hiding this comment.
For spark we are using open lineage to collect the lineage but other query engines have their own support for getting lineage data
feng-tao
approved these changes
Oct 12, 2022
Signed-off-by: Allison Suarez Miranda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.