Skip to content

fix: support capitalized table names #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2022
Merged

fix: support capitalized table names #2004

merged 4 commits into from
Oct 6, 2022

Conversation

allisonsuarez
Copy link
Contributor

Since search has to analyze a lowercase string, this change in frontend looks at the key to get the table name to display to users rather than the name coming from the search field name.

@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder category:ui labels Oct 5, 2022
@allisonsuarez
added comment
144d9a5 
Signed-off-by: Allison Suarez Miranda <[email protected]>
kristenarmes
kristenarmes approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@kristenarmes kristenarmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the function comment for clarification about the usage!

@allisonsuarez
fix comment
8825e0d 
Signed-off-by: Allison Suarez Miranda <[email protected]>
@allisonsuarez
added unit test for get name
82c16de 
Signed-off-by: Allison Suarez Miranda <[email protected]>
Golodhros
Golodhros approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allisonsuarez allisonsuarez merged commit 85fe9fc into main Oct 6, 2022
@allisonsuarez allisonsuarez deleted the asm-keys-for-name branch October 6, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Golodhros Golodhros Golodhros approved these changes

@kristenarmes kristenarmes kristenarmes approved these changes

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

Assignees
No one assigned
Labels
area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allisonsuarez @Golodhros @kristenarmes