Skip to content

feat: Allow null values set for empty props in neo4j unwind publisher and multiple rels between nodes #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kristenarmes
Copy link
Contributor

@kristenarmes kristenarmes commented Sep 13, 2022

Signed-off-by: Kristen Armes [email protected]

Summary of Changes

  • Added publisher config PRESERVE_EMPTY_PROPS to Neo4jCsvUnwindPublisher
    • True (default): existing behavior of publishing node or relation properties even if they have empty values
    • False: set empty properties to NULL so they will not show up on the nodes or relations
  • Allow multiple relations between the same two nodes when not publishing reverse relations
    • Note: must add key as an attribute for the relation
    • Now has the relation key as part of the merge statement so unique relations will all be published
    • Appends the loader-generated key to the generated file names in case there are more than one for the same groupings of nodes and relations

Tests

N/A

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

…ow multiple rels between two nodes if they have unique keys

Signed-off-by: Kristen Armes <[email protected]>
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label Sep 13, 2022
@kristenarmes kristenarmes marked this pull request as ready for review September 13, 2022 17:35
@kristenarmes kristenarmes requested a review from a team as a code owner September 13, 2022 17:35
Copy link
Contributor

@allisonsuarez allisonsuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks Kristen

@kristenarmes kristenarmes merged commit c08f251 into amundsen-io:main Sep 13, 2022
@kristenarmes kristenarmes deleted the allow-neo4j-null-empty-props branch September 13, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants