Skip to content

fix: Fix hideNonClickableBadges configuration #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ozandogrultan
Copy link
Contributor

Signed-off-by: Ozan Dogrultan [email protected]

Summary of Changes

At the moment, when hideNonClickableBadges is configured to be true, the column badges are hidden everywhere in the app. This PR makes to changes to hide them only on the homepage.

Tests

Existing tests should pass with these changes.

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@@ -18,6 +18,7 @@ const COLUMN_BADGE_CATEGORY = 'column';
export interface BadgeListProps {
badges: Badge[];
onBadgeClick: (badgeText: string) => void;
hideNonClickableBadges?: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to test if this works with a new test

Signed-off-by: Ozan Dogrultan <[email protected]>
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot!

@Golodhros Golodhros merged commit 6bac23f into amundsen-io:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants