Skip to content

fix: no reason to raise a 404 when a user has no bookmarks or reads #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2022
Merged

fix: no reason to raise a 404 when a user has no bookmarks or reads #1964

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74d4f2e
added error logging for follow
allisonsuarez Aug 17, 2022
251a6b2
fix: we should not raise a 4040 when someone has no bookmarks
allisonsuarez Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions metadata/metadata_service/proxy/neo4j_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1611,9 +1611,6 @@ def get_table_by_user_relation(self, *, user_email: str, relation_type: UserReso

table_records = self._execute_cypher_query(statement=query, param_dict={'user_key': user_email})

if not table_records:
raise NotFoundException('User {user_id} does not {relation} any resources'.format(user_id=user_email,
relation=relation_type))
results = []
for record in table_records:
results.append(PopularTable(
Expand Down Expand Up @@ -1644,8 +1641,6 @@ def get_frequently_used_tables(self, *, user_email: str) -> Dict[str, Any]:

table_records = self._execute_cypher_query(statement=query, param_dict={'query_key': user_email})

if not table_records:
raise NotFoundException('User {user_id} does not READ any resources'.format(user_id=user_email))
results = []

for record in table_records:
Expand Down