feat: Extend Lineage list view configuration #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ozan Dogrultan <[email protected]>
ozandogrultan
requested review from
Golodhros,
ttannis,
allisonsuarez,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd and
dechoma
as code owners
Signed-off-by: Ozan Dogrultan <[email protected]>
|
@Golodhros @allisonsuarez Can you please review this as we are planning to use this feature on our production environment? |
Golodhros
reviewed
Aug 22, 2022
| @@ -18,9 +18,18 @@ const isTableLinkDisabled = (table: LineageItem) => { | |||
| const config = AppConfig.tableLineage; | |||
There was a problem hiding this comment.
Is there a function to retrieve this configuration instead of using it directly?
There was a problem hiding this comment.
I've added a new utility function to return the disableAppListLinks configuration
Signed-off-by: Ozan Dogrultan <[email protected]>
Signed-off-by: Ozan Dogrultan <[email protected]>
Golodhros
reviewed
Aug 22, 2022
| */ | ||
| export function getTableLineageDisableAppListLinks() { | ||
| return AppConfig.tableLineage.disableAppListLinks; | ||
| } |
There was a problem hiding this comment.
Thanks, it only needs a test though!
Signed-off-by: Ozan Dogrultan <[email protected]>
|
Not sure why the build looks like it's failed, I see that some tasks are just skipped and others are passed |
Signed-off-by: Ozan Dogrultan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ozan Dogrultan [email protected]
Summary of Changes
This PR extends the recently added Lineage list view configuration to include
badgeskey, to be able to also disable Lineage list view UI links based on a badges list configuration.Tests
No test changes are needed.
Documentation
No documentation changes are needed.
CheckList
Make sure you have checked all steps below to ensure a timely review.