Skip to content

feat: Neo4j driver 4.4.5 on metadata #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Aug 16, 2022
Merged

feat: Neo4j driver 4.4.5 on metadata #1952

merged 23 commits into from
Aug 16, 2022

Conversation

allisonsuarez
Copy link
Contributor

@allisonsuarez allisonsuarez commented Aug 4, 2022

  • Updated neo4j python driver to v4.4.5
  • Added PROXY_DATABASE_NAME to specify database to use if your neo4j version supports multiple databases
  • Made PROXY_PORT config optional
    Note: this is the bare minimum necessary changes to support newer neo4j versions, a more extensive refactor is required to get the neo4j_proxy working in line with the most up to date Cypher/Neo4j driver changes.

Signed-off-by: Allison Suarez Miranda <[email protected]>
@boring-cyborg boring-cyborg bot added area:metadata From the metadata folder category:api labels Aug 4, 2022
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
@allisonsuarez allisonsuarez changed the title feat: Neo4j driver 4.5.5 on metadata feat: Neo4j driver 4.4.5 on metadata Aug 4, 2022
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
… error for safe list get

Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Copy link

@dkunitsk dkunitsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Only two outstanding nits:

  1. about the safe_list_get being unlist
  2. about using *args, **kwargs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metadata From the metadata folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants