-
Notifications
You must be signed in to change notification settings - Fork 970
feat: Add config to hide non-clickable badges #1943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add config to hide non-clickable badges #1943
Conversation
Signed-off-by: Ozan Dogrultan <[email protected]>
Signed-off-by: Ozan Dogrultan <[email protected]>
Signed-off-by: Ozan Dogrultan <[email protected]>
@Golodhros could you review this please? 🙏🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some lines on the documentation for the frontend configuration about this option?
Signed-off-by: Ozan Dogrultan <[email protected]>
@Golodhros This is done. Can you please review again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ozan Dogrultan [email protected]
Summary of Changes
Adds a new boolean configuration,
hideNonClickableBadges
, to control whether non-clickable (only column type at the moment) badges should be shown on the homepage or not. This potentially improves the user experience and declutters the homepage.Tests
Added a new unit test for the config util.
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.