Skip to content

feat: Add config to hide non-clickable badges #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ozandogrultan
Copy link
Contributor

@ozandogrultan ozandogrultan commented Jul 27, 2022

Signed-off-by: Ozan Dogrultan [email protected]

Summary of Changes

Adds a new boolean configuration, hideNonClickableBadges, to control whether non-clickable (only column type at the moment) badges should be shown on the homepage or not. This potentially improves the user experience and declutters the homepage.

Tests

Added a new unit test for the config util.

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Signed-off-by: Ozan Dogrultan <[email protected]>
@ozandogrultan
Copy link
Contributor Author

@Golodhros could you review this please? 🙏🏼

Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some lines on the documentation for the frontend configuration about this option?

Signed-off-by: Ozan Dogrultan <[email protected]>
@ozandogrultan ozandogrultan requested a review from a team as a code owner August 9, 2022 12:31
@ozandogrultan
Copy link
Contributor Author

Could you add some lines on the documentation for the frontend configuration about this option?

@Golodhros This is done. Can you please review again?

@ozandogrultan ozandogrultan requested a review from Golodhros August 9, 2022 12:32
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozandogrultan ozandogrultan requested a review from Golodhros August 9, 2022 12:40
@Golodhros Golodhros merged commit f30e9e1 into amundsen-io:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants