Skip to content

feat-use-retryable-query-executor #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Owen-CH-Leung
Copy link
Contributor

@Owen-CH-Leung Owen-CH-Leung commented Jul 23, 2022

My previous PR here didn't use the built-in retry-able query executor, which would result in connection lost with AWS neptune after amundsen runs for a while. Hence this PR targets to rectify the error and make sure all queries use the retryable query executor

Summary of Changes

All queries made to neptune will use the built-in retryable query executor

Tests

Tested in my company's environment and runs well

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@boring-cyborg boring-cyborg bot added area:metadata From the metadata folder category:proxy labels Jul 23, 2022
Signed-off-by: Owen-LCH <[email protected]>
Signed-off-by: owenlch <[email protected]>
@Owen-CH-Leung Owen-CH-Leung force-pushed the feat-use-retryable-query-executor branch from a8041fb to cb2a368 Compare July 23, 2022 12:48
@Owen-CH-Leung Owen-CH-Leung marked this pull request as ready for review July 23, 2022 12:50
@Owen-CH-Leung Owen-CH-Leung requested a review from a team as a code owner July 23, 2022 12:50
@Owen-CH-Leung
Copy link
Contributor Author

@feng-tao Can I seek your review & approval for this ? Thanks

@stale
Copy link

stale bot commented Aug 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Aug 10, 2022
@stale stale bot removed the stale label Sep 10, 2022
@feng-tao feng-tao merged commit d36896f into amundsen-io:main Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metadata From the metadata folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants