Skip to content

fix: Show the column in the center of the table when navigating to a column link #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kristenarmes
Copy link
Contributor

Signed-off-by: Kristen Armes [email protected]

Summary of Changes

When navigating to a link for a specific column, this change will scroll the column row to the center of the table instead of the top so it doesn't hide behind the sticky header.

Tests

N/A

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

…e top so it doesn't hide behind the sticky header

Signed-off-by: Kristen Armes <[email protected]>
@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder category:ui labels Jul 22, 2022
@kristenarmes kristenarmes marked this pull request as ready for review July 22, 2022 21:57
@kristenarmes kristenarmes merged commit c3dab36 into amundsen-io:main Jul 22, 2022
@kristenarmes kristenarmes deleted the fix-column-link-scroll-into-view branch July 22, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants