feat: Exclude stats icon if configured stat types are the only ones present #1939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kristen Armes [email protected]
Summary of Changes
This change adds a config to allow adding a list of stat types where, if they are the only ones present for a column, the stats icon will not be displayed next to that column's name. This is useful in the case of columns only having very common stats, such as column usage, so the users will not click on the column expecting to see more info. The default value is an empty list so this will only affect those who configure it.
Tests
Added a test for the config, and modified tests for determining whether the icon is displayed for a given column
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.