Skip to content

feat: Sticky TabsComponent and Table headers #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kristenarmes
Copy link
Contributor

Signed-off-by: Kristen Armes [email protected]

Summary of Changes

  • Make the TabsComponent and the Table header sticky when you scroll on pages that use them
  • Hide the Expand/Collapse All button in the top right of the TableDetailPage when the page is resized to smaller than a set width to not overflow on top of the tabs (this action is still available by clicking the arrow in the header in the top right of the table)
  • Small bug fix to close the right side panel on the TableDetailPage if it is open when the tab is changed

Tests

N/A

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder category:ui labels Jul 5, 2022
@kristenarmes kristenarmes marked this pull request as ready for review July 5, 2022 19:52
@media (max-width: calc(#{$base-max-width - $width-increment-5})) {
.has-open-right-panel .nav.nav-tabs {
width: 100%;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I call polishing a UI! 🎉

Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristenarmes kristenarmes merged commit 8093039 into amundsen-io:main Jul 5, 2022
@kristenarmes kristenarmes deleted the table-details-sticky-header branch July 5, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants