Skip to content

fix: Update bounds for databuilder google-auth versions #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ozandogrultan
Copy link
Contributor

@ozandogrultan ozandogrultan commented Jun 30, 2022

Signed-off-by: Ozan Dogrultan [email protected]

Summary of Changes

This PR fixes a conflicting package versioning for google-auth in Databuilder. At the moment google-api-python-client requires google-auth>=1.16.0, however google-auth>=2.6.0 line in databuilder setup.py conflicts with this constraint. The changes introduces less strict bounds to fix this conflict.

Tests

N/A

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder category:ui labels Jul 5, 2022
Signed-off-by: Ozan Dogrultan <[email protected]>
@ozandogrultan
Copy link
Contributor Author

@feng-tao Could you help with the review please?

@feng-tao feng-tao merged commit fdf0f0a into amundsen-io:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants