-
Notifications
You must be signed in to change notification settings - Fork 970
feat: add get_lineage support for neptune backend #1915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add get_lineage support for neptune backend #1915
Conversation
Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md) |
4bfb0f2
to
d3b6c29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a test for the feature? and thanks for the contribution
the CI fails |
3d88f7b
to
1e8254c
Compare
Just pushed another commit which fixed the failed CI on my local environment. It should pass this time |
Sure. Let me take a look at the existing test cases and see how I can modify them |
b748f6c
to
7bfc41f
Compare
@feng-tao Would you mind sharing with me how I can contribute to adding more test cases for the gremlin proxy that I've modified ? I've looked at this file which is for neo4j proxy but I couldn't find a similar one for neptune / gremlin proxy. The closest file I could find is this but it didn't look similar to that of neo4j... Thanks a lot for your help. |
@Owen-LCH I think we could add a new test file, but we could do it in a different pr. The ci still fails with mypy error:
|
Signed-off-by: owenlch <[email protected]>
Signed-off-by: owenlch <[email protected]>
Signed-off-by: owenlch <[email protected]>
Signed-off-by: owenlch <[email protected]>
cd7f8e4
to
aef8a45
Compare
@feng-tao Sure. Let's do it in a seperate PR. I just pushed a new commit which fixes the mypy error & the import sequence error that is returned from |
@feng-tao Can I seek your help to start the unit test again ? Thanks |
just restart the ci |
Thanks. I saw the CI tests are all passed. We can merge it to main now =) |
Awesome work, congrats on your first merged pull request! |
Summary of Changes
Currently, using AWS Neptune as the backend, the get_lienage function is not implemented at the
NeptuneGremlinProxy
,AbstractGremlinProxy
andBaseProxy
, which means that the lineage graph & the frontend tab displaying lineage does not work properly due to the missing implementation. For details, you can refer to this chat :https://amundsenworkspace.slack.com/archives/C01A87A5EUU/p1653483057967299?thread_ts=1653374819.089879&cid=C01A87A5EUU
Hence, this PR attempts to create such functionality so that lineage works fine using Neptune as backend.
Tests
I tested the code using my company's aws environment (which uses AWS neptune & opensearch as the backend) and it worked fine.
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.