Skip to content

fix: Updating tour feature to store wildcard path instead of the url path #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

kristenarmes
Copy link
Contributor

Signed-off-by: Kristen Armes [email protected]

Summary of Changes

Previously, if you configured a product/feature tour by using a wildcard path, the actual path of the page you visited would be stored rather than with the wildcard. This resulted in the tour showing up for every new page you visited under the wildcard. This change stores the actual configured path so that if wildcards are used, it will only show the tour on the first page you visit.

Tests

Updated tests to handle the change to the return value of getProductToursFor

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

…oid showing it more than once

Signed-off-by: Kristen Armes <[email protected]>
@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder category:ui labels Jun 16, 2022
@kristenarmes kristenarmes marked this pull request as ready for review June 16, 2022 17:41
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the fix!

@Golodhros Golodhros merged commit 991b07f into amundsen-io:main Jun 16, 2022
@kristenarmes kristenarmes deleted the tour-wildcard-path branch June 16, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants