Skip to content

fix: Various fixes to nested columns based on feedback #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

kristenarmes
Copy link
Contributor

Signed-off-by: Kristen Armes [email protected]

Summary of Changes

  • Make vertical spacing between sections in side table/column details panels smaller
  • Left align badges (use margin-right between badges instead of margin-left)
  • Display "Copied to clipboard" popover when clicking on the copy column name or link buttons
  • Show a non-truncated column type for complex types if it is shorter than a given length
  • Add the type in the right side panel in case users want to expand it without having to return their focus to the main table
  • Click Esc button to close the right side panel
  • Fix hover effect on expand/collapse icons for individual rows
  • Move focus to right panel when it opens so hitting tab will cycle over the elements there
  • Add btn-link styling to the Expand/Collapse all nested button in the top right so it will have a focus effect

Tests

  • Test that the column details panel renders the type

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder category:ui labels Jun 14, 2022
@kristenarmes kristenarmes marked this pull request as ready for review June 14, 2022 00:53
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Kristen Armes <[email protected]>
@Golodhros Golodhros merged commit 8a22ce8 into amundsen-io:main Jun 14, 2022
@kristenarmes kristenarmes deleted the nested-column-feedback-fixes branch June 14, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants