-
Notifications
You must be signed in to change notification settings - Fork 970
feat: Add clickable rows to table detail page and new expand/collapse arrow icons #1897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add clickable rows to table detail page and new expand/collapse arrow icons #1897
Conversation
Signed-off-by: Kristen Armes <[email protected]>
Signed-off-by: Kristen Armes <[email protected]>
frontend/amundsen_application/static/js/components/Table/styles.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
frontend/amundsen_application/static/js/components/Table/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/components/Table/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/pages/TableDetailPage/RequestDescriptionText/index.tsx
Show resolved
Hide resolved
frontend/amundsen_application/static/js/pages/TableDetailPage/RequestDescriptionText/index.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristen Armes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
className="request-description body-link" | ||
href="JavaScript:void(0)" | ||
type="button" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better indeed
Signed-off-by: Kristen Armes [email protected]
Summary of Changes
Request Description
link to the right side panel and removed the action column from the main table since it was now redundantCopy column name
button in the right side panel to copy the whole column name path rather than only the name itself to be more usefulRows all expanded:

Rows collapsed:

Tests
Request Description
link in the side panelRequestDescriptionText
component to accept props, so updated the tests to reflect thatDocumentation
CheckList
Make sure you have checked all steps below to ensure a timely review.