Skip to content

feat: Add clickable rows to table detail page and new expand/collapse arrow icons #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

kristenarmes
Copy link
Contributor

Signed-off-by: Kristen Armes [email protected]

Summary of Changes

  • Added clickable rows to Table Detail Page to allow users to expand the right side panel by clicking on the row instead of only the column name, and included a hover box shadow that matches the same effect used on the dashboard page
  • The active row that has been clicked is now indigo rather than dark gray to differentiate more from nested column rows
  • Use new tree structure arrow icons that point right when a row is collapsed and down when a row is expanded
  • Added the Request Description link to the right side panel and removed the action column from the main table since it was now redundant
  • Fixed the Copy column name button in the right side panel to copy the whole column name path rather than only the name itself to be more useful

Rows all expanded:
Screen Shot 2022-06-10 at 10 52 44 AM

Rows collapsed:
Screen Shot 2022-06-10 at 10 54 57 AM

Tests

  • Added tests for clickable rows in the table component
  • Added tests for the Request Description link in the side panel
  • Removed tests around the action buttons column since that no longer exists
  • Changed the RequestDescriptionText component to accept props, so updated the tests to reflect that

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder category:ui labels Jun 10, 2022
Signed-off-by: Kristen Armes <[email protected]>
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Kristen Armes <[email protected]>
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

className="request-description body-link"
href="JavaScript:void(0)"
type="button"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better indeed

@Golodhros Golodhros merged commit 76620f2 into amundsen-io:main Jun 13, 2022
@kristenarmes kristenarmes deleted the add-clickable-rows-to-table branch June 13, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants