Skip to content

feat: Adding expand all/collapse all functionality for nested columns #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/amundsen_application/static/.betterer.results
Original file line number Diff line number Diff line change
Expand Up @@ -652,9 +652,9 @@ exports[`eslint`] = {
"js/pages/TableDetailPage/WatermarkLabel/index.tsx:2189911402": [
[29, 22, 21, "Must use destructuring props assignment", "587844958"]
],
"js/pages/TableDetailPage/index.tsx:953038643": [
[160, 2, 20, "key should be placed after componentDidUpdate", "3916788587"],
[206, 6, 13, "Do not use setState in componentDidUpdate", "57229240"]
"js/pages/TableDetailPage/index.tsx:105919838": [
[161, 2, 20, "key should be placed after componentDidUpdate", "3916788587"],
[208, 6, 13, "Do not use setState in componentDidUpdate", "57229240"]
],
"js/utils/textUtils.ts:2545492889": [
[19, 6, 46, "Unexpected lexical declaration in case block.", "156477898"]
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
// Copyright Contributors to the Amundsen project.
// SPDX-License-Identifier: Apache-2.0

import * as React from 'react';
import { v4 as uuidv4 } from 'uuid';

import { IconSizes } from 'interfaces';
import { IconProps } from './types';
import { DEFAULT_FILL_COLOR } from './constants';

export const DoubleChevronDown: React.FC<IconProps> = ({
size = IconSizes.REGULAR,
fill = DEFAULT_FILL_COLOR,
}: IconProps) => {
const id = `double_chevron_down_${uuidv4()}`;

return (
<svg
width={size}
height={size}
id={id}
viewBox="0 0 24 24"
fill="none"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M12 15.586L7.70697 11.293L6.29297 12.707L12 18.414L17.707 12.707L16.293 11.293L12 15.586Z"
fill={fill}
/>
<path
d="M17.707 7.707L16.293 6.293L12 10.586L7.70697 6.293L6.29297 7.707L12 13.414L17.707 7.707Z"
fill={fill}
/>
</svg>
);
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
// Copyright Contributors to the Amundsen project.
// SPDX-License-Identifier: Apache-2.0

import * as React from 'react';
import { v4 as uuidv4 } from 'uuid';

import { IconSizes } from 'interfaces';
import { IconProps } from './types';
import { DEFAULT_FILL_COLOR } from './constants';

export const DoubleChevronUp: React.FC<IconProps> = ({
size = IconSizes.REGULAR,
fill = DEFAULT_FILL_COLOR,
}: IconProps) => {
const id = `double_chevron_up_${uuidv4()}`;

return (
<svg
width={size}
height={size}
id={id}
viewBox="0 0 24 24"
fill="none"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M6.29297 11.293L7.70697 12.707L12 8.414L16.293 12.707L17.707 11.293L12 5.586L6.29297 11.293Z"
fill={fill}
/>
<path
d="M6.29297 16.293L7.70697 17.707L12 13.414L16.293 17.707L17.707 16.293L12 10.586L6.29297 16.293Z"
fill={fill}
/>
</svg>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@ export * from './InformationIcon';
export * from './Binoculars';
export * from './Chat';
export * from './TableIcon';
export * from './DoubleChevronUp';
export * from './DoubleChevronDown';
Loading