-
Notifications
You must be signed in to change notification settings - Fork 970
feat: Nested columns special type rows and expand by default #1872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Nested columns special type rows and expand by default #1872
Conversation
…efault unless max config is reached Signed-off-by: Kristen Armes <[email protected]>
Signed-off-by: Kristen Armes <[email protected]>
frontend/amundsen_application/static/js/components/Table/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/components/Table/index.tsx
Outdated
Show resolved
Hide resolved
{arrayOpenerLabel} {mapOpenerLabel} | ||
</span> | ||
</td> | ||
{[...Array(additionalTableColCount)].map((value, index) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would Array(additionalTableColCount).map work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the way I came across when looking for a how to add a dynamic number of elements. It does add the correct number of empty <td>
s by iterating over the count, and the reason I'm doing this is bc otherwise the background-color was being cut off at the width of the first table column td
frontend/amundsen_application/static/js/components/Table/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/components/Table/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/features/ColumnList/ColumnType/index.tsx
Show resolved
Hide resolved
frontend/amundsen_application/static/js/components/Table/index.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristen Armes <[email protected]>
frontend/amundsen_application/static/js/components/Table/index.tsx
Outdated
Show resolved
Hide resolved
…om config Signed-off-by: Kristen Armes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks a lot, great work!
…n-io#1872) * Special type handling rows for nested columns, and expand nested by default unless max config is reached Signed-off-by: Kristen Armes <[email protected]> * Using constant for row height Signed-off-by: Kristen Armes <[email protected]> * Addressing PR comments Signed-off-by: Kristen Armes <[email protected]> * Passing max number of nested cols as an option to Table instead of from config Signed-off-by: Kristen Armes <[email protected]>
Signed-off-by: Kristen Armes [email protected]
Summary of Changes
This work builds on the nested columns changes outlined in this RFC. The changes included here are disabled for now until the nested columns dropdown behavior is enabled.
Examples of the special type rows:
Array of structs

Map

Array of maps

Tests
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.