feat: Adding nested columns to be displayed in the column dropdowns as rows #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (currently disabled) Signed-off-by: Kristen Armes <[email protected]>
kristenarmes
requested review from
Golodhros,
ttannis,
allisonsuarez,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd and
dechoma
as code owners
Golodhros
reviewed
May 18, 2022
frontend/amundsen_application/static/js/components/Table/index.spec.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/components/Table/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/components/Table/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/components/Table/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/components/Table/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/components/Table/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/features/ColumnList/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/features/ColumnList/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/features/ColumnList/index.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristen Armes <[email protected]>
Golodhros
approved these changes
May 20, 2022
| formatChildrenData?: (item: any, index: number) => FormattedDataType; | ||
| /** Function used to pre expand the right panel with the designated details */ | ||
| preExpandRightPanel?: (columnDetails: FormattedDataType) => void; |
This was referenced Jun 15, 2022
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
…s rows (amundsen-io#1865) * Adding nested columns to be displayed in the column dropdowns as rows (currently disabled) Signed-off-by: Kristen Armes <[email protected]> * Addressing PR comments Signed-off-by: Kristen Armes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kristen Armes [email protected]
Summary of Changes
These changes repurpose the column dropdown functionality to display nested columns rather than column details. Clicking on the column names will display the details instead of the dropdown (see #1831).
This dropdown usage will only be available to those using
TypeMetadataon the backend, where the complex types are parsed in databuilder and stored in the db. For all others, the existing frontend parsing/display behavior for nested columns has been preserved. All users regardless ofTypeMetadatausage will no longer be able to view column details through the dropdown.Please note that in this specific PR the changes described here have been disabled. Once the changes reach parity with the existing frontend parsing behavior, it will be enabled.
With new changes, once enabled:
Current view for all, and for those not using
TypeMetadata:Tests
New tests added to test the new dropdown functionality. Also, navigating to a column link for nested columns is being tested as well, since each intermediate column between the top level and the one being navigated to must be preexpanded.
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.