-
Notifications
You must be signed in to change notification settings - Fork 970
feat: Search Service Highlighting #1856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
kristenarmes
approved these changes
May 12, 2022
Signed-off-by: Allison Suarez Miranda <[email protected]>
dkunitsk
reviewed
May 13, 2022
wey-gu
added a commit
to wey-gu/amundsen
that referenced
this pull request
May 15, 2022
note: still need amundsen-io#1856 to be included to work as highlight_options introduced in frontend app but not yet merged in search service
4 tasks
wey-gu
added a commit
to wey-gu/amundsen
that referenced
this pull request
May 15, 2022
note: still need amundsen-io#1856 to be included to work as highlight_options introduced in frontend app but not yet merged in search service Signed-off-by: wey-gu <[email protected]>
wey-gu
added a commit
to wey-gu/amundsen
that referenced
this pull request
May 17, 2022
note: still need amundsen-io#1856 to be included to work as highlight_options introduced in frontend app but not yet merged in search service Signed-off-by: wey-gu <[email protected]>
wey-gu
added a commit
to wey-gu/amundsen
that referenced
this pull request
May 24, 2022
note: still need amundsen-io#1856 to be included to work as highlight_options introduced in frontend app but not yet merged in search service Signed-off-by: wey-gu <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
dkunitsk
reviewed
May 25, 2022
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
dkunitsk
reviewed
Jun 1, 2022
dkunitsk
approved these changes
Jun 1, 2022
allisonsuarez
added a commit
that referenced
this pull request
Jun 9, 2022
* feat: Search Service Highlighting Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed unit test Signed-off-by: Allison Suarez Miranda <[email protected]> * put attrdict access in try in case of keyerror Signed-off-by: Allison Suarez Miranda <[email protected]> * stupid Signed-off-by: Allison Suarez Miranda <[email protected]> * ??? Signed-off-by: Allison Suarez Miranda <[email protected]> * mock mathc Signed-off-by: Allison Suarez Miranda <[email protected]> * debug Signed-off-by: Allison Suarez Miranda <[email protected]> * all unit tests pass Signed-off-by: Allison Suarez Miranda <[email protected]> * lint Signed-off-by: Allison Suarez Miranda <[email protected]> * cinf fix Signed-off-by: Allison Suarez Miranda <[email protected]> * check that request has highlights Signed-off-by: Allison Suarez Miranda <[email protected]> * implemented feedback Signed-off-by: Allison Suarez Miranda <[email protected]> * empty checks Signed-off-by: Allison Suarez Miranda <[email protected]> * updated format response tests anhd put them in utils test file Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed all tests Signed-off-by: Allison Suarez Miranda <[email protected]> * lint Signed-off-by: Allison Suarez Miranda <[email protected]> * mypy Signed-off-by: Allison Suarez Miranda <[email protected]> * isort Signed-off-by: Allison Suarez Miranda <[email protected]> * added another unit test Signed-off-by: Allison Suarez Miranda <[email protected]> * isort Signed-off-by: Allison Suarez Miranda <[email protected]> * major oopsie Signed-off-by: Allison Suarez Miranda <[email protected]> * some changes Signed-off-by: Allison Suarez Miranda <[email protected]> * updated test Signed-off-by: Allison Suarez Miranda <[email protected]> * latets pending marshmallow3-annotations bump Signed-off-by: Allison Suarez Miranda <[email protected]> * remove debugging line Signed-off-by: Allison Suarez Miranda <[email protected]> * isort Signed-off-by: Allison Suarez Miranda <[email protected]> * bumped marshmallow3-annotation to 1.1.0 Signed-off-by: Allison Suarez Miranda <[email protected]> * typing extensions issue attempt to fix Signed-off-by: Allison Suarez Miranda <[email protected]> * had to convert sttrdict and lsit in the end Signed-off-by: Allison Suarez Miranda <[email protected]> * sort imports Signed-off-by: Allison Suarez Miranda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:common
From common folder
area:databuilder
From databuilder folder
area:search
From the search folder
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API highlighting options
Added Optional highlight options to search request, these allow specification of highlights for fields in each resource like:
Default highlighting
If
"enable_highlight": true
is for a resource the default highlight in ES will be:There are other highlights for specific resources like matching columns and column descriptions for tables, and chart and query name highlights for dashboards.
Databuilder dependency
If you are not using the latest mappings from databuilder which include
"term_vector" : "with_positions_offsets"
.