Skip to content

fix: fix misaligned source icon #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022

Conversation

youngyjd
Copy link
Member

Summary of Changes

Before:
Screen Shot 2022-05-11 at 2 21 25 PM

Now:
Screen Shot 2022-05-11 at 2 22 03 PM

Tests

css change. no new unit test created.

Documentation

NA

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Signed-off-by: Junda Yang <[email protected]>
@youngyjd youngyjd force-pushed the fix-misaligned-source-icon branch from 129c826 to ded3d54 Compare May 11, 2022 21:34
@feng-tao
Copy link
Member

cc @Golodhros

Copy link
Contributor

@kristenarmes kristenarmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on our end
cc @Golodhros

@youngyjd
Copy link
Member Author

I don't have merge access on frontend code. Could @kristenarmes or @Golodhros please take care of it?

@Golodhros Golodhros merged commit 853dbe1 into amundsen-io:main May 12, 2022
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants