fix: toggle filter should clear when off #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allison Suarez Miranda <[email protected]>
allisonsuarez
requested review from
Golodhros,
ttannis,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd and
dechoma
as code owners
dkunitsk
approved these changes
May 5, 2022
Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Allison Suarez Miranda <[email protected]>
Golodhros
reviewed
May 5, 2022
frontend/amundsen_application/static/js/pages/SearchPage/SearchFilter/ToggleFilter/index.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Allison Suarez Miranda <[email protected]>
allisonsuarez
added a commit
that referenced
this pull request
May 12, 2022
* chore: update search service to use new search mappings Signed-off-by: Allison Suarez Miranda <[email protected]> * needed fields back Signed-off-by: Allison Suarez Miranda <[email protected]> * updated index name to point to new index Signed-off-by: Allison Suarez Miranda <[email protected]> * Added deprecation warning log to old ES client Signed-off-by: Allison Suarez Miranda <[email protected]> * made fixtures match new mappings for tests Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed other unit ests Signed-off-by: Allison Suarez Miranda <[email protected]> * lint Signed-off-by: Allison Suarez Miranda <[email protected]> * remove print and import unused Signed-off-by: Allison Suarez Miranda <[email protected]> * added docs explaining how to transition to /v2/search Signed-off-by: Allison Suarez Miranda <[email protected]> * bit more doc Signed-off-by: Allison Suarez Miranda <[email protected]> * change to keep BW compatibility and add new functionality Signed-off-by: Allison Suarez Miranda <[email protected]> * a bit of cleanup and comments for clarity Signed-off-by: Allison Suarez Miranda <[email protected]> * more cleanup and manual testing of new search Signed-off-by: Allison Suarez Miranda <[email protected]> * updated all unit tests and initialize proxy classes according to bww comp functionality Signed-off-by: Allison Suarez Miranda <[email protected]> * lint Signed-off-by: Allison Suarez Miranda <[email protected]> * updated docs Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed flake and mypy errors Signed-off-by: Allison Suarez Miranda <[email protected]> * more mypy Signed-off-by: Allison Suarez Miranda <[email protected]> * sort imports in v3 Signed-off-by: Allison Suarez Miranda <[email protected]> * implemented most feedback need to do more manual testing and run unit tests + linter Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed import Signed-off-by: Allison Suarez Miranda <[email protected]> * updated doc Signed-off-by: Allison Suarez Miranda <[email protected]> * oops Signed-off-by: Allison Suarez Miranda <[email protected]> * fix Signed-off-by: Allison Suarez Miranda <[email protected]> * fix mypy issue Signed-off-by: Allison Suarez Miranda <[email protected]> * type removed Signed-off-by: Allison Suarez Miranda <[email protected]> * more config cleanup and some clarifications Signed-off-by: Allison Suarez Miranda <[email protected]> * fix: toggle filter should clear when off (#1848) * fix: toggle filter should clear when off Signed-off-by: Allison Suarez Miranda <[email protected]> * lint fix Signed-off-by: Allison Suarez Miranda <[email protected]> * updated unit test Signed-off-by: Allison Suarez Miranda <[email protected]> * suggestion Signed-off-by: Allison Suarez Miranda <[email protected]> * Refactoring various column details and adding type metadata to the table metadata FE model (#1847) Signed-off-by: Kristen Armes <[email protected]> * fix: fixes tour not resetting on different pages (#1849) Signed-off-by: Marcos Iglesias <[email protected]> * fix: better behavior for search filters (#1852) * fix: better behavior for application of filters Signed-off-by: Allison Suarez Miranda <[email protected]> * explicit comparison to None Signed-off-by: Allison Suarez Miranda <[email protected]> * 2nd round of feedback plus more context Signed-off-by: Allison Suarez Miranda <[email protected]> * added filters change from different PR and removed deprecated configs Signed-off-by: Allison Suarez Miranda <[email protected]> * chore: update search service to use new search mappings Signed-off-by: Allison Suarez Miranda <[email protected]> * needed fields back Signed-off-by: Allison Suarez Miranda <[email protected]> * updated index name to point to new index Signed-off-by: Allison Suarez Miranda <[email protected]> * Added deprecation warning log to old ES client Signed-off-by: Allison Suarez Miranda <[email protected]> * made fixtures match new mappings for tests Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed other unit ests Signed-off-by: Allison Suarez Miranda <[email protected]> * lint Signed-off-by: Allison Suarez Miranda <[email protected]> * remove print and import unused Signed-off-by: Allison Suarez Miranda <[email protected]> * added docs explaining how to transition to /v2/search Signed-off-by: Allison Suarez Miranda <[email protected]> * bit more doc Signed-off-by: Allison Suarez Miranda <[email protected]> * change to keep BW compatibility and add new functionality Signed-off-by: Allison Suarez Miranda <[email protected]> * a bit of cleanup and comments for clarity Signed-off-by: Allison Suarez Miranda <[email protected]> * more cleanup and manual testing of new search Signed-off-by: Allison Suarez Miranda <[email protected]> * updated all unit tests and initialize proxy classes according to bww comp functionality Signed-off-by: Allison Suarez Miranda <[email protected]> * lint Signed-off-by: Allison Suarez Miranda <[email protected]> * updated docs Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed flake and mypy errors Signed-off-by: Allison Suarez Miranda <[email protected]> * more mypy Signed-off-by: Allison Suarez Miranda <[email protected]> * sort imports in v3 Signed-off-by: Allison Suarez Miranda <[email protected]> * implemented most feedback need to do more manual testing and run unit tests + linter Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed import Signed-off-by: Allison Suarez Miranda <[email protected]> * updated doc Signed-off-by: Allison Suarez Miranda <[email protected]> * oops Signed-off-by: Allison Suarez Miranda <[email protected]> * fix Signed-off-by: Allison Suarez Miranda <[email protected]> * fix mypy issue Signed-off-by: Allison Suarez Miranda <[email protected]> * type removed Signed-off-by: Allison Suarez Miranda <[email protected]> * more config cleanup and some clarifications Signed-off-by: Allison Suarez Miranda <[email protected]> * 2nd round of feedback plus more context Signed-off-by: Allison Suarez Miranda <[email protected]> * added filters change from different PR and removed deprecated configs Signed-off-by: Allison Suarez Miranda <[email protected]> * Revert "Merge branch 'asm-search-with-new-mappings' of github.com:amundsen-io/amundsen into asm-search-with-new-mappings" This reverts commit 49c5c34, reversing changes made to e14b541. * fix args kwards Signed-off-by: Allison Suarez Miranda <[email protected]> * deprecating config Signed-off-by: Allison Suarez Miranda <[email protected]> * deprecating config Signed-off-by: Allison Suarez Miranda <[email protected]> * args fix Signed-off-by: Allison Suarez Miranda <[email protected]> * readme update Signed-off-by: Allison Suarez Miranda <[email protected]> * conf Signed-off-by: Allison Suarez Miranda <[email protected]> * flake Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed new Signed-off-by: Allison Suarez Miranda <[email protected]> * type ignore Signed-off-by: Allison Suarez Miranda <[email protected]> * https://peps.python.org/pep-0484/\#arbitrary-argument-lists-and-default-argument-values Signed-off-by: Allison Suarez Miranda <[email protected]> * Empty-Commit Co-authored-by: Kristen Armes <[email protected]> Co-authored-by: Marcos Iglesias <[email protected]>
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
* fix: toggle filter should clear when off Signed-off-by: Allison Suarez Miranda <[email protected]> * lint fix Signed-off-by: Allison Suarez Miranda <[email protected]> * updated unit test Signed-off-by: Allison Suarez Miranda <[email protected]> * suggestion Signed-off-by: Allison Suarez Miranda <[email protected]>
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
) * chore: update search service to use new search mappings Signed-off-by: Allison Suarez Miranda <[email protected]> * needed fields back Signed-off-by: Allison Suarez Miranda <[email protected]> * updated index name to point to new index Signed-off-by: Allison Suarez Miranda <[email protected]> * Added deprecation warning log to old ES client Signed-off-by: Allison Suarez Miranda <[email protected]> * made fixtures match new mappings for tests Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed other unit ests Signed-off-by: Allison Suarez Miranda <[email protected]> * lint Signed-off-by: Allison Suarez Miranda <[email protected]> * remove print and import unused Signed-off-by: Allison Suarez Miranda <[email protected]> * added docs explaining how to transition to /v2/search Signed-off-by: Allison Suarez Miranda <[email protected]> * bit more doc Signed-off-by: Allison Suarez Miranda <[email protected]> * change to keep BW compatibility and add new functionality Signed-off-by: Allison Suarez Miranda <[email protected]> * a bit of cleanup and comments for clarity Signed-off-by: Allison Suarez Miranda <[email protected]> * more cleanup and manual testing of new search Signed-off-by: Allison Suarez Miranda <[email protected]> * updated all unit tests and initialize proxy classes according to bww comp functionality Signed-off-by: Allison Suarez Miranda <[email protected]> * lint Signed-off-by: Allison Suarez Miranda <[email protected]> * updated docs Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed flake and mypy errors Signed-off-by: Allison Suarez Miranda <[email protected]> * more mypy Signed-off-by: Allison Suarez Miranda <[email protected]> * sort imports in v3 Signed-off-by: Allison Suarez Miranda <[email protected]> * implemented most feedback need to do more manual testing and run unit tests + linter Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed import Signed-off-by: Allison Suarez Miranda <[email protected]> * updated doc Signed-off-by: Allison Suarez Miranda <[email protected]> * oops Signed-off-by: Allison Suarez Miranda <[email protected]> * fix Signed-off-by: Allison Suarez Miranda <[email protected]> * fix mypy issue Signed-off-by: Allison Suarez Miranda <[email protected]> * type removed Signed-off-by: Allison Suarez Miranda <[email protected]> * more config cleanup and some clarifications Signed-off-by: Allison Suarez Miranda <[email protected]> * fix: toggle filter should clear when off (amundsen-io#1848) * fix: toggle filter should clear when off Signed-off-by: Allison Suarez Miranda <[email protected]> * lint fix Signed-off-by: Allison Suarez Miranda <[email protected]> * updated unit test Signed-off-by: Allison Suarez Miranda <[email protected]> * suggestion Signed-off-by: Allison Suarez Miranda <[email protected]> * Refactoring various column details and adding type metadata to the table metadata FE model (amundsen-io#1847) Signed-off-by: Kristen Armes <[email protected]> * fix: fixes tour not resetting on different pages (amundsen-io#1849) Signed-off-by: Marcos Iglesias <[email protected]> * fix: better behavior for search filters (amundsen-io#1852) * fix: better behavior for application of filters Signed-off-by: Allison Suarez Miranda <[email protected]> * explicit comparison to None Signed-off-by: Allison Suarez Miranda <[email protected]> * 2nd round of feedback plus more context Signed-off-by: Allison Suarez Miranda <[email protected]> * added filters change from different PR and removed deprecated configs Signed-off-by: Allison Suarez Miranda <[email protected]> * chore: update search service to use new search mappings Signed-off-by: Allison Suarez Miranda <[email protected]> * needed fields back Signed-off-by: Allison Suarez Miranda <[email protected]> * updated index name to point to new index Signed-off-by: Allison Suarez Miranda <[email protected]> * Added deprecation warning log to old ES client Signed-off-by: Allison Suarez Miranda <[email protected]> * made fixtures match new mappings for tests Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed other unit ests Signed-off-by: Allison Suarez Miranda <[email protected]> * lint Signed-off-by: Allison Suarez Miranda <[email protected]> * remove print and import unused Signed-off-by: Allison Suarez Miranda <[email protected]> * added docs explaining how to transition to /v2/search Signed-off-by: Allison Suarez Miranda <[email protected]> * bit more doc Signed-off-by: Allison Suarez Miranda <[email protected]> * change to keep BW compatibility and add new functionality Signed-off-by: Allison Suarez Miranda <[email protected]> * a bit of cleanup and comments for clarity Signed-off-by: Allison Suarez Miranda <[email protected]> * more cleanup and manual testing of new search Signed-off-by: Allison Suarez Miranda <[email protected]> * updated all unit tests and initialize proxy classes according to bww comp functionality Signed-off-by: Allison Suarez Miranda <[email protected]> * lint Signed-off-by: Allison Suarez Miranda <[email protected]> * updated docs Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed flake and mypy errors Signed-off-by: Allison Suarez Miranda <[email protected]> * more mypy Signed-off-by: Allison Suarez Miranda <[email protected]> * sort imports in v3 Signed-off-by: Allison Suarez Miranda <[email protected]> * implemented most feedback need to do more manual testing and run unit tests + linter Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed import Signed-off-by: Allison Suarez Miranda <[email protected]> * updated doc Signed-off-by: Allison Suarez Miranda <[email protected]> * oops Signed-off-by: Allison Suarez Miranda <[email protected]> * fix Signed-off-by: Allison Suarez Miranda <[email protected]> * fix mypy issue Signed-off-by: Allison Suarez Miranda <[email protected]> * type removed Signed-off-by: Allison Suarez Miranda <[email protected]> * more config cleanup and some clarifications Signed-off-by: Allison Suarez Miranda <[email protected]> * 2nd round of feedback plus more context Signed-off-by: Allison Suarez Miranda <[email protected]> * added filters change from different PR and removed deprecated configs Signed-off-by: Allison Suarez Miranda <[email protected]> * Revert "Merge branch 'asm-search-with-new-mappings' of github.com:amundsen-io/amundsen into asm-search-with-new-mappings" This reverts commit 49c5c34, reversing changes made to e14b541. * fix args kwards Signed-off-by: Allison Suarez Miranda <[email protected]> * deprecating config Signed-off-by: Allison Suarez Miranda <[email protected]> * deprecating config Signed-off-by: Allison Suarez Miranda <[email protected]> * args fix Signed-off-by: Allison Suarez Miranda <[email protected]> * readme update Signed-off-by: Allison Suarez Miranda <[email protected]> * conf Signed-off-by: Allison Suarez Miranda <[email protected]> * flake Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed new Signed-off-by: Allison Suarez Miranda <[email protected]> * type ignore Signed-off-by: Allison Suarez Miranda <[email protected]> * https://peps.python.org/pep-0484/\#arbitrary-argument-lists-and-default-argument-values Signed-off-by: Allison Suarez Miranda <[email protected]> * Empty-Commit Co-authored-by: Kristen Armes <[email protected]> Co-authored-by: Marcos Iglesias <[email protected]>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
* fix: toggle filter should clear when off Signed-off-by: Allison Suarez Miranda <[email protected]> * lint fix Signed-off-by: Allison Suarez Miranda <[email protected]> * updated unit test Signed-off-by: Allison Suarez Miranda <[email protected]> * suggestion Signed-off-by: Allison Suarez Miranda <[email protected]>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
) * chore: update search service to use new search mappings Signed-off-by: Allison Suarez Miranda <[email protected]> * needed fields back Signed-off-by: Allison Suarez Miranda <[email protected]> * updated index name to point to new index Signed-off-by: Allison Suarez Miranda <[email protected]> * Added deprecation warning log to old ES client Signed-off-by: Allison Suarez Miranda <[email protected]> * made fixtures match new mappings for tests Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed other unit ests Signed-off-by: Allison Suarez Miranda <[email protected]> * lint Signed-off-by: Allison Suarez Miranda <[email protected]> * remove print and import unused Signed-off-by: Allison Suarez Miranda <[email protected]> * added docs explaining how to transition to /v2/search Signed-off-by: Allison Suarez Miranda <[email protected]> * bit more doc Signed-off-by: Allison Suarez Miranda <[email protected]> * change to keep BW compatibility and add new functionality Signed-off-by: Allison Suarez Miranda <[email protected]> * a bit of cleanup and comments for clarity Signed-off-by: Allison Suarez Miranda <[email protected]> * more cleanup and manual testing of new search Signed-off-by: Allison Suarez Miranda <[email protected]> * updated all unit tests and initialize proxy classes according to bww comp functionality Signed-off-by: Allison Suarez Miranda <[email protected]> * lint Signed-off-by: Allison Suarez Miranda <[email protected]> * updated docs Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed flake and mypy errors Signed-off-by: Allison Suarez Miranda <[email protected]> * more mypy Signed-off-by: Allison Suarez Miranda <[email protected]> * sort imports in v3 Signed-off-by: Allison Suarez Miranda <[email protected]> * implemented most feedback need to do more manual testing and run unit tests + linter Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed import Signed-off-by: Allison Suarez Miranda <[email protected]> * updated doc Signed-off-by: Allison Suarez Miranda <[email protected]> * oops Signed-off-by: Allison Suarez Miranda <[email protected]> * fix Signed-off-by: Allison Suarez Miranda <[email protected]> * fix mypy issue Signed-off-by: Allison Suarez Miranda <[email protected]> * type removed Signed-off-by: Allison Suarez Miranda <[email protected]> * more config cleanup and some clarifications Signed-off-by: Allison Suarez Miranda <[email protected]> * fix: toggle filter should clear when off (amundsen-io#1848) * fix: toggle filter should clear when off Signed-off-by: Allison Suarez Miranda <[email protected]> * lint fix Signed-off-by: Allison Suarez Miranda <[email protected]> * updated unit test Signed-off-by: Allison Suarez Miranda <[email protected]> * suggestion Signed-off-by: Allison Suarez Miranda <[email protected]> * Refactoring various column details and adding type metadata to the table metadata FE model (amundsen-io#1847) Signed-off-by: Kristen Armes <[email protected]> * fix: fixes tour not resetting on different pages (amundsen-io#1849) Signed-off-by: Marcos Iglesias <[email protected]> * fix: better behavior for search filters (amundsen-io#1852) * fix: better behavior for application of filters Signed-off-by: Allison Suarez Miranda <[email protected]> * explicit comparison to None Signed-off-by: Allison Suarez Miranda <[email protected]> * 2nd round of feedback plus more context Signed-off-by: Allison Suarez Miranda <[email protected]> * added filters change from different PR and removed deprecated configs Signed-off-by: Allison Suarez Miranda <[email protected]> * chore: update search service to use new search mappings Signed-off-by: Allison Suarez Miranda <[email protected]> * needed fields back Signed-off-by: Allison Suarez Miranda <[email protected]> * updated index name to point to new index Signed-off-by: Allison Suarez Miranda <[email protected]> * Added deprecation warning log to old ES client Signed-off-by: Allison Suarez Miranda <[email protected]> * made fixtures match new mappings for tests Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed other unit ests Signed-off-by: Allison Suarez Miranda <[email protected]> * lint Signed-off-by: Allison Suarez Miranda <[email protected]> * remove print and import unused Signed-off-by: Allison Suarez Miranda <[email protected]> * added docs explaining how to transition to /v2/search Signed-off-by: Allison Suarez Miranda <[email protected]> * bit more doc Signed-off-by: Allison Suarez Miranda <[email protected]> * change to keep BW compatibility and add new functionality Signed-off-by: Allison Suarez Miranda <[email protected]> * a bit of cleanup and comments for clarity Signed-off-by: Allison Suarez Miranda <[email protected]> * more cleanup and manual testing of new search Signed-off-by: Allison Suarez Miranda <[email protected]> * updated all unit tests and initialize proxy classes according to bww comp functionality Signed-off-by: Allison Suarez Miranda <[email protected]> * lint Signed-off-by: Allison Suarez Miranda <[email protected]> * updated docs Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed flake and mypy errors Signed-off-by: Allison Suarez Miranda <[email protected]> * more mypy Signed-off-by: Allison Suarez Miranda <[email protected]> * sort imports in v3 Signed-off-by: Allison Suarez Miranda <[email protected]> * implemented most feedback need to do more manual testing and run unit tests + linter Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed import Signed-off-by: Allison Suarez Miranda <[email protected]> * updated doc Signed-off-by: Allison Suarez Miranda <[email protected]> * oops Signed-off-by: Allison Suarez Miranda <[email protected]> * fix Signed-off-by: Allison Suarez Miranda <[email protected]> * fix mypy issue Signed-off-by: Allison Suarez Miranda <[email protected]> * type removed Signed-off-by: Allison Suarez Miranda <[email protected]> * more config cleanup and some clarifications Signed-off-by: Allison Suarez Miranda <[email protected]> * 2nd round of feedback plus more context Signed-off-by: Allison Suarez Miranda <[email protected]> * added filters change from different PR and removed deprecated configs Signed-off-by: Allison Suarez Miranda <[email protected]> * Revert "Merge branch 'asm-search-with-new-mappings' of github.com:amundsen-io/amundsen into asm-search-with-new-mappings" This reverts commit 49c5c34, reversing changes made to e14b541. * fix args kwards Signed-off-by: Allison Suarez Miranda <[email protected]> * deprecating config Signed-off-by: Allison Suarez Miranda <[email protected]> * deprecating config Signed-off-by: Allison Suarez Miranda <[email protected]> * args fix Signed-off-by: Allison Suarez Miranda <[email protected]> * readme update Signed-off-by: Allison Suarez Miranda <[email protected]> * conf Signed-off-by: Allison Suarez Miranda <[email protected]> * flake Signed-off-by: Allison Suarez Miranda <[email protected]> * fixed new Signed-off-by: Allison Suarez Miranda <[email protected]> * type ignore Signed-off-by: Allison Suarez Miranda <[email protected]> * https://peps.python.org/pep-0484/\#arbitrary-argument-lists-and-default-argument-values Signed-off-by: Allison Suarez Miranda <[email protected]> * Empty-Commit Co-authored-by: Kristen Armes <[email protected]> Co-authored-by: Marcos Iglesias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allison Suarez Miranda [email protected]
Summary of Changes
Tests
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.