✨ Yobee Ad Integration | New #40278
Merged
✨ Yobee Ad Integration | New #40278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support to amp-ad for the AdMatic type.
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for a new Yobee ad vendor integration for amp-ad, enhancing the ad network support with documentation, example updates, and necessary integration code changes.
- Added Yobee vendor documentation and examples.
- Implemented Yobee vendor integration scripts and configuration updates.
- Updated integration registration to include Yobee in both legacy and ESM examples.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/amp-ad/amp-ad.md | Added Yobee reference to vendor list. |
| examples/amp-ad/ads.amp.html | Injected Yobee option and sample amp-ad block. |
| examples/amp-ad/ads.amp.esm.html | Injected Yobee option and sample amp-ad block for ESM. |
| ads/vendors/yobee.md | Added documentation for Yobee ad implementation. |
| ads/vendors/yobee.js | Introduced Yobee vendor integration logic. |
| ads/_config.js | Updated ad configuration with Yobee support. |
| 3p/vendors/yobee.js | Registered Yobee integration for 3p context. |
| 3p/integration.js | Registered Yobee integration along with other vendors. |
powerivq
requested changes
Apr 26, 2025
|
@fatihkaya84 Ping. |
|
|
@powerivq kind reminder :) Best. |
powerivq
requested changes
May 5, 2025
Thanks. |
powerivq
approved these changes
May 7, 2025
Vue-Pu
added a commit
to Vue-Pu/amphtml
that referenced
this pull request
May 12, 2025
* Pixad Ad Integration * updated trailing whitespace. * fix * Update pixad.js * Update integration.js * Update amp-ad.md * Update pixad.md * AdMatic Ad Integration | New add support to amp-ad for the AdMatic type. * update * Update admatic.md * yobee * Update yobee.md * update * Update integration.js * Update yobee.js [ampproject-amphtml] Implement feature ). Yobee Ad Integration ✨ New features addressed by this pull request. Merges with( ampproject#40278), (#7) For substantial changes, first file an Intent-to-Implement (I2I) issue at go.amp.dev/i2i. # References: - AMP code contribution docs: go.amp.dev/contribute/code - First time setup (required for CI checks): go.amp.dev/getting-started # Emojis for categorizing pull request :✨ New feature Implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support to amp-ad for the Yobee type.